linux-kernel - Re: [PATCH v13 3/8] clk: Use devm_ in the register fixed factor clock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <153979087829.5275.6249138489771592939@swboyd.mtv.corp.google.com>
Date:   Wed, 17 Oct 2018 08:41:18 -0700
From:   Stephen Boyd <sboyd@...nel.org>
To:     Niklas Cassel <niklas.cassel@...aro.org>,
        bjorn.andersson@...aro.org, ilia.lin@...il.com
Cc:     Ricardo Salveti <rsalveti@...lveti.net>, mturquette@...libre.com,
        robh+dt@...nel.org, mark.rutland@....com, andy.gross@...aro.org,
        david.brown@...aro.org, will.deacon@....com,
        Amit Kucheria <amit.kucheria@...aro.org>,
        linux-clk@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-arm-msm@...r.kernel.org,
        linux-soc@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v13 3/8] clk: Use devm_ in the register fixed factor clock

Quoting Niklas Cassel (2018-10-14 13:21:22)
> On Fri, Oct 12, 2018 at 03:08:17PM -0700, Stephen Boyd wrote:
> > Quoting Ricardo Salveti (2018-09-14 11:53:02)
> > > On Thu, Jun 14, 2018 at 6:55 PM <ilia.lin@...il.com> wrote:
> > > >
> > > > From: Ilia Lin <ilialin@...eaurora.org>
> > > >
> > > > Use devm_clk_hw_register instead of clk_hw_register
> > > > to simplify the usage of this API. This way drivers that call
> > > > the clk_hw_register_fixed_factor won't need to maintain
> > > > a data structure for further cleanup.
> > > >
> > > > Signed-off-by: Ilia Lin <ilialin@...eaurora.org>
> > > > Tested-by: Amit Kucheria <amit.kucheria@...aro.org>
> > > > ---
> > > >  drivers/clk/clk-fixed-factor.c | 2 +-
> > > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > >
> > > > diff --git a/drivers/clk/clk-fixed-factor.c b/drivers/clk/clk-fixed-factor.c
> > > > index a5d402de5584..8e39bda8e596 100644
> > > > --- a/drivers/clk/clk-fixed-factor.c
> > > > +++ b/drivers/clk/clk-fixed-factor.c
> > > > @@ -94,7 +94,7 @@ struct clk_hw *clk_hw_register_fixed_factor(struct device *dev,
> > > >         init.num_parents = 1;
> > > >
> > > >         hw = &fix->hw;
> > > > -       ret = clk_hw_register(dev, hw);
> > > > +       ret = devm_clk_hw_register(dev, hw);
> > > 
> > > Not sure what is the current state of this patch-set, but this change
> > > breaks drivers calling clk_hw_register_fixed_factor with a NULL dev
> > > (e.g. imx_clk_fixed_factor), as devm_clk_hw_register needs a valid dev
> > > for devres_add to work.
> > > 
> > 
> > Yep. Probably better to just have a driver register the clk_hw structure
> > itself with the clk framework vs. trying to get it right here in the
> > generic type registration function.
> > 
> 
> Hello Ilia, Stephen,
> 
> As you know this patch series is needed to get DVFS working on msm8996.
> 
> Ilia, are you planning on submitting a new patch set for this, or would
> you prefer if we submitted a new patch version for you?
> 
> Looking at this patch series, this appears to be the only outstanding
> review comment.

Sorry, you were too hopeful :/

> Stephen, do you have any review comments on this series?
> 

Yes, my nitpick should be easy to resolve and then it's just a few open
questions after that. Otherwise things seem fine and the CPU can run
really fast without bumping up the voltages?