linux-kernel - RE: [PATCH 3/5] Drivers: hv: kvp: Fix the recent regression caused by incorrect clean-up

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <PU1P153MB0169C3D595A7E427A5A63CB1BFFF0@PU1P153MB0169.APCP153.PROD.OUTLOOK.COM>
Date:   Wed, 17 Oct 2018 18:01:15 +0000
From:   Dexuan Cui <decui@...rosoft.com>
To:     Greg KH <gregkh@...uxfoundation.org>,
        KY Srinivasan <kys@...rosoft.com>
CC:     "olaf@...fle.de" <olaf@...fle.de>,
        Stephen Hemminger <sthemmin@...rosoft.com>,
        "jasowang@...hat.com" <jasowang@...hat.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Stable@...r.kernel.org" <Stable@...r.kernel.org>,
        Michael Kelley <mikelley@...rosoft.com>,
        "apw@...onical.com" <apw@...onical.com>,
        "devel@...uxdriverproject.org" <devel@...uxdriverproject.org>,
        vkuznets <vkuznets@...hat.com>,
        Haiyang Zhang <haiyangz@...rosoft.com>
Subject: RE: [PATCH 3/5] Drivers: hv: kvp: Fix the recent regression caused by
 incorrect clean-up

> From: devel <driverdev-devel-bounces@...uxdriverproject.org> On Behalf Of
> Greg KH
> Sent: Tuesday, October 16, 2018 22:07
> > ...
> > +	case KVP_OP_GET:
> > +		message->body.kvp_get.data.key_size =
> > +			utf16s_to_utf8s(
> > +			(wchar_t *)in_msg->body.kvp_get.data.key,
> > +			in_msg->body.kvp_get.data.key_size,
> > +			UTF16_LITTLE_ENDIAN,
> > +			message->body.kvp_get.data.key,
> > +			HV_KVP_EXCHANGE_MAX_KEY_SIZE - 1) + 1;
> 
> Worst indentation ever :(
> 
> Yeah, I know it follows the others above it, but you should reconsider
> it in the future...
> greg k-h

Agreed. We should consider improving this in future.

-- Dexuan