linux-kernel - Re: [Lkcamp] [PATCH 3/4] kbuild: Removes unnecessary shadowed local variable and optimize testing.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d3185020-b1aa-3eeb-b8e7-ecaefd624236@koikeco.de>
Date:   Wed, 17 Oct 2018 00:06:49 -0300
From:   Helen Koike <helen@...keco.de>
To:     Leonardo Brás <leobras.c@...il.com>,
        lkcamp@...ts.libreplanetbr.org
Cc:     x86@...nel.org, linux-kbuild@...r.kernel.org,
        Matthew Wilcox <willy6545@...il.com>,
        linux-kernel@...r.kernel.org,
        Masahiro Yamada <yamada.masahiro@...ionext.com>,
        Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
        Andy Lutomirski <luto@...nel.org>,
        "H. Peter Anvin" <hpa@...or.com>,
        Michal Marek <michal.lkml@...kovi.net>,
        Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [Lkcamp] [PATCH 3/4] kbuild: Removes unnecessary shadowed local
 variable and optimize testing.

Hi Leonardo,

On 10/16/18 9:09 PM, Leonardo Brás wrote:
>     Removes an unnecessary shadowed local variable (start).
>     Optimize test of isdigit:
>     - If isalpha returns true, isdigit will return false, so no need to test.

This patch does two different things, it should be in two separated patches.

> 
> Signed-off-by: Leonardo Brás <leobras.c@...il.com>
> ---
>  scripts/asn1_compiler.c | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/scripts/asn1_compiler.c b/scripts/asn1_compiler.c
> index c146020fc783..08bb6e5fd6ad 100644
> --- a/scripts/asn1_compiler.c
> +++ b/scripts/asn1_compiler.c
> @@ -413,7 +413,7 @@ static void tokenise(char *buffer, char *end)
>  
>  			/* Handle string tokens */
>  			if (isalpha(*p)) {
> -				const char **dir, *start = p;
> +				const char **dir;
>  
>  				/* Can be a directive, type name or element
>  				 * name.  Find the end of the name.
> @@ -454,10 +454,9 @@ static void tokenise(char *buffer, char *end)
>  
>  				tokens[tix++].token_type = TOKEN_TYPE_NAME;
>  				continue;
> -			}
> +			} else if (isdigit(*p)) {
> +				/* Handle numbers */

Actually you can't do that, p is being altered in the first if statement.

>  
> -			/* Handle numbers */
> -			if (isdigit(*p)) {
>  				/* Find the end of the number */
>  				q = p + 1;
>  				while (q < nl && (isdigit(*q)))
> 

Regards
Helen