linux-kernel - Re: [PATCH] atm: zatm: Fix empty body Clang warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20181018.154133.1613303373005587833.davem@davemloft.net>
Date:   Thu, 18 Oct 2018 15:41:33 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     natechancellor@...il.com
Cc:     3chas3@...il.com, linux-atm-general@...ts.sourceforge.net,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] atm: zatm: Fix empty body Clang warnings

From: Nathan Chancellor <natechancellor@...il.com>
Date: Wed, 17 Oct 2018 11:04:19 -0700

> Clang warns:
> 
> drivers/atm/zatm.c:513:7: error: while loop has empty body
> [-Werror,-Wempty-body]
>         zwait;
>              ^
> drivers/atm/zatm.c:513:7: note: put the semicolon on a separate line to
> silence this warning
> 
> Get rid of this warning by using an empty do-while loop. While we're at
> it, add parentheses to make it clear that this is a function-like macro.
> 
> Link: https://github.com/ClangBuiltLinux/linux/issues/42
> Suggested-by: Masahiro Yamada <yamada.masahiro@...ionext.com>
> Signed-off-by: Nathan Chancellor <natechancellor@...il.com>

Applied.