linux-kernel - Re: [PATCH v2] xen/blkfront: avoid NULL blkfront

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20181018235417.GB36047@konrads-mbp.lan>
Date:   Thu, 18 Oct 2018 19:54:17 -0400
From:   Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>
To:     Vasilis Liaskovitis <vliaskovitis@...e.com>
Cc:     Roger Pau Monné <roger.pau@...rix.com>,
        xen-devel@...ts.xenproject.org, linux-kernel@...r.kernel.org,
        linux-block@...r.kernel.org, jgross@...e.com,
        boris.ostrovsky@...cle.com, axboe@...nel.dk
Subject: Re: [PATCH v2] xen/blkfront: avoid NULL blkfront_info dereference on
 device removal

On Mon, Oct 15, 2018 at 04:25:56PM +0200, Vasilis Liaskovitis wrote:
> On Mon, 2018-10-15 at 16:02 +0200, Roger Pau Monné wrote:
> > 
> > > This results in a NULL pointer BUG when blkfront_remove and
> > > blkif_free
> > > try to access the failing device's NULL struct blkfront_info.
> > > 
> > > 
> > I guess this is a candidate for backporting?
> > 
> 
> yes, I think so. At least for kernels >=4.5, which could face this
> issue due to commit c31ecf6c12 (this frees the struct blkinfo in the
> failing path of talk_to_blkback).

OK, applied with Cc: stable@...r.kernel.org
> 
> thanks, 
> 
> - Vasilis
> 
>