[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20181018060734.f7ysidkikuoxnkkw@mwanda>
Date: Thu, 18 Oct 2018 09:07:34 +0300
From: Dan Carpenter <dan.carpenter@...cle.com>
To: Shreeya Patel <shreeya.patel23498@...il.com>
Cc: Marcelo Schmitt <marcelo.schmitt1@...il.com>, lars@...afoo.de,
Michael.Hennerich@...log.com, jic23@...nel.org, knaack.h@....de,
pmeerw@...erw.net, gregkh@...uxfoundation.org,
linux-iio@...r.kernel.org, devel@...verdev.osuosl.org,
linux-kernel@...r.kernel.org, kernel-usp@...glegroups.com
Subject: Re: [PATCH] Staging iio/adc: fixes parenthesis alignment
I feel like these are overly nit-picky...
I understand that everyone is picky about different things. For
example, I have a prefered style for error handling. So two days ago
there was a new staging driver and it used label name like
"goto kmalloc_failed;" and I looked until I found an error handling bug
and then I said, "Here is a bug, plus your label names are bad." When
people have bad style but it doesn't lead to bugs then I let them get
away with it.
regards,
dan carpenter
Powered by blists - more mailing lists