[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <tip-36b8d4628d3cc8f5a748e508cce8673bc00fc63c@git.kernel.org>
Date: Wed, 17 Oct 2018 23:18:37 -0700
From: tip-bot for Jarod Wilson <tipbot@...or.com>
To: linux-tip-commits@...r.kernel.org
Cc: alexander.shishkin@...ux.intel.com, peterz@...radead.org,
linux-kernel@...r.kernel.org, wcohen@...hat.com,
namhyung@...nel.org, mingo@...nel.org, eranian@...gle.com,
jarod@...hat.com, hpa@...or.com, tglx@...utronix.de,
acme@...hat.com, jolsa@...hat.com
Subject: [tip:perf/urgent] perf tools: Fix use of alternatives to find JDIR
Commit-ID: 36b8d4628d3cc8f5a748e508cce8673bc00fc63c
Gitweb: https://git.kernel.org/tip/36b8d4628d3cc8f5a748e508cce8673bc00fc63c
Author: Jarod Wilson <jarod@...hat.com>
AuthorDate: Thu, 6 Sep 2018 18:18:12 -0400
Committer: Arnaldo Carvalho de Melo <acme@...hat.com>
CommitDate: Tue, 16 Oct 2018 12:06:47 -0300
perf tools: Fix use of alternatives to find JDIR
When a build is run from something like a cron job, the user's $PATH is
rather minimal, of note, not including /usr/sbin in my own case. Because
of that, an automated rpm package build ultimately fails to find
libperf-jvmti.so, because somewhere within the build, this happens...
/bin/sh: alternatives: command not found
/bin/sh: alternatives: command not found
Makefile.config:849: No openjdk development package found, please install
JDK package, e.g. openjdk-8-jdk, java-1.8.0-openjdk-devel
...and while the build continues, libperf-jvmti.so isn't built, and
things fall down when rpm tries to find all the %files specified. Exact
same system builds everything just fine when the job is launched from a
login shell instead of a cron job, since alternatives is in $PATH, so
openjdk is actually found.
The test required to get into this section of code actually specifies
the full path, as does a block just above it, so let's do that here too.
Signed-off-by: Jarod Wilson <jarod@...hat.com>
Acked-by: Jiri Olsa <jolsa@...hat.com>
Cc: Alexander Shishkin <alexander.shishkin@...ux.intel.com>
Cc: Namhyung Kim <namhyung@...nel.org>
Cc: Peter Zijlstra <peterz@...radead.org>
Cc: Stephane Eranian <eranian@...gle.com>
Cc: William Cohen <wcohen@...hat.com>
Fixes: d4dfdf00d43e ("perf jvmti: Plug compilation into perf build")
Link: http://lkml.kernel.org/r/20180906221812.11167-1-jarod@redhat.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@...hat.com>
---
tools/perf/Makefile.config | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/Makefile.config b/tools/perf/Makefile.config
index f6d1a03c7523..e30d20fb482d 100644
--- a/tools/perf/Makefile.config
+++ b/tools/perf/Makefile.config
@@ -833,7 +833,7 @@ ifndef NO_JVMTI
JDIR=$(shell /usr/sbin/update-java-alternatives -l | head -1 | awk '{print $$3}')
else
ifneq (,$(wildcard /usr/sbin/alternatives))
- JDIR=$(shell alternatives --display java | tail -1 | cut -d' ' -f 5 | sed 's%/jre/bin/java.%%g')
+ JDIR=$(shell /usr/sbin/alternatives --display java | tail -1 | cut -d' ' -f 5 | sed 's%/jre/bin/java.%%g')
endif
endif
ifndef JDIR
Powered by blists - more mailing lists