[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <5BC84E60.60501@st.com>
Date: Thu, 18 Oct 2018 09:12:01 +0000
From: Pascal PAILLET-LME <p.paillet@...com>
To: Axel Lin <axel.lin@...ics.com>, Mark Brown <broonie@...nel.org>
CC: Liam Girdwood <lgirdwood@...il.com>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] regulator: stpmic1: Return REGULATOR_MODE_INVALID for
invalid mode
Hi Axel,
Thank you for your comment. As the driver is merged, I will make the
change in a future patch-set.
Best regards, Pascal.
Le 10/09/2018 10:52 AM, Axel Lin a écrit :
> -EINVAL is not a valid return value for .of_map_mode, return
> REGULATOR_MODE_INVALID instead.
>
> Signed-off-by: Axel Lin <axel.lin@...ics.com>
> ---
> drivers/regulator/stpmic1_regulator.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/regulator/stpmic1_regulator.c b/drivers/regulator/stpmic1_regulator.c
> index 96f18083a3b6..e15634edb8ce 100644
> --- a/drivers/regulator/stpmic1_regulator.c
> +++ b/drivers/regulator/stpmic1_regulator.c
> @@ -441,7 +441,7 @@ static unsigned int stpmic1_map_mode(unsigned int mode)
> case STPMIC1_BUCK_MODE_LP:
> return REGULATOR_MODE_STANDBY;
> default:
> - return -EINVAL;
> + return REGULATOR_MODE_INVALID;
> }
> }
>
Powered by blists - more mailing lists