linux-kernel - Re: [PATCH v13 00/12] livepatch: Atomic replace feature

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181018133425.o3ykjjuqede3mmht@treble>
Date:   Thu, 18 Oct 2018 08:34:25 -0500
From:   Josh Poimboeuf <jpoimboe@...hat.com>
To:     Petr Mladek <pmladek@...e.com>
Cc:     Jiri Kosina <jikos@...nel.org>, Miroslav Benes <mbenes@...e.cz>,
        Jason Baron <jbaron@...mai.com>,
        Joe Lawrence <joe.lawrence@...hat.com>,
        Evgenii Shatokhin <eshatokhin@...tuozzo.com>,
        live-patching@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v13 00/12] livepatch: Atomic replace feature

On Mon, Oct 15, 2018 at 02:37:01PM +0200, Petr Mladek wrote:
> The atomic replace allows to create cumulative patches. They
> are useful when you maintain many livepatches and want to remove
> one that is lower on the stack. In addition it is very useful when
> more patches touch the same function and there are dependencies
> between them.
> 
> Now, the question is if 13 is a lucky number. I hope so
> and that this version might get merged. Any feedback?
>
> Not only from Mirek, please ;-)
> 
> 
> Changes against v12:
> 
>   + Finish freeing the patch using workqueues to prevent
>     deadlock against kobject code.
> 
>   + Check for valid pointers when initializing the dynamic
>     lists objects and functions.
> 
>   + Mark klp_free_objects_dynamic() static.
> 
>   + Improved documentation and fixed typos

Other than the few comments I made, this is looking good to me.  I'm
optimistic about v14.  It's probably best to not merge a v13 anyway. ;-)
Thanks a lot for sticking with it.

-- 
Josh