linux-kernel - Re: [PATCH V2 6/6] usb: host: Add ability to build new Broadcom STB USB drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.44L0.1810181032460.1521-100000@iolanthe.rowland.org>
Date:   Thu, 18 Oct 2018 10:35:47 -0400 (EDT)
From:   Alan Stern <stern@...land.harvard.edu>
To:     Al Cooper <alcooperx@...il.com>
cc:     linux-kernel@...r.kernel.org, Alban Bedel <albeu@...e.fr>,
        Alex Elder <elder@...aro.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Arnd Bergmann <arnd@...db.de>,
        Avi Fishman <avifishman70@...il.com>,
        <bcm-kernel-feedback-list@...adcom.com>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Chunfeng Yun <chunfeng.yun@...iatek.com>,
        "David S. Miller" <davem@...emloft.net>,
        <devicetree@...r.kernel.org>, Dmitry Osipenko <digetx@...il.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "Gustavo A. R. Silva" <gustavo@...eddedor.com>,
        Hans de Goede <hdegoede@...hat.com>,
        James Hogan <jhogan@...nel.org>,
        Jianguo Sun <sunjianguo1@...wei.com>,
        Johan Hovold <johan@...nel.org>,
        Kees Cook <keescook@...omium.org>, <linux-usb@...r.kernel.org>,
        Lu Baolu <baolu.lu@...ux.intel.com>,
        Mark Rutland <mark.rutland@....com>,
        Martin Blumenstingl <martin.blumenstingl@...glemail.com>,
        Mathias Nyman <mathias.nyman@...el.com>,
        Mathias Nyman <mathias.nyman@...ux.intel.com>,
        Mauro Carvalho Chehab <mchehab+samsung@...nel.org>,
        Rishabh Bhatnagar <rishabhb@...eaurora.org>,
        Rob Herring <robh+dt@...nel.org>, Roger Quadros <rogerq@...com>
Subject: Re: [PATCH V2 6/6] usb: host: Add ability to build new Broadcom STB
 USB drivers

On Wed, 17 Oct 2018, Al Cooper wrote:

> Add the build system changes needed to get the Broadcom STB XHCI,
> EHCI and OHCI functionality working. The link order for XHCI was
> changed in the Makefile because of the way STB XHCI, EHCI and OHCI
> controllers share a port which requires that the XHCI driver be
> initialized first. Also update MAINTAINERS.
> 
> Signed-off-by: Al Cooper <alcooperx@...il.com>
> ---
>  MAINTAINERS               |  9 +++++++++
>  drivers/usb/host/Kconfig  | 29 +++++++++++++++++++++++++++++
>  drivers/usb/host/Makefile | 18 ++++++++++++------
>  3 files changed, 50 insertions(+), 6 deletions(-)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 6ac000cc006d..7e062dcbe173 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -3006,6 +3006,15 @@ S:	Supported
>  F:	drivers/gpio/gpio-brcmstb.c
>  F:	Documentation/devicetree/bindings/gpio/brcm,brcmstb-gpio.txt
>  
> +BROADCOM BRCMSTB USB XHCI, EHCI and OHCI DRIVERS

This should say "XHCI and EHCI".  There is no Broadcom OHCI driver any 
more.

> +M:	Al Cooper <alcooperx@...il.com>
> +L:	linux-usb@...r.kernel.org
> +L:	bcm-kernel-feedback-list@...adcom.com
> +S:	Maintained
> +F:	drivers/usb/host/xhci-brcm.*
> +F:	drivers/usb/host/ohci-brcm.c

This should say "ehci-brcm.c".

> +F:	Documentation/devicetree/bindings/usb/brcm,bcm7445-*.txt
> +
>  BROADCOM BRCMSTB USB2 and USB3 PHY DRIVER
>  M:	Al Cooper <alcooperx@...il.com>
>  L:	linux-kernel@...r.kernel.org
> diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig
> index 1a4ea98cac2a..112de3334389 100644
> --- a/drivers/usb/host/Kconfig
> +++ b/drivers/usb/host/Kconfig
> @@ -94,6 +94,35 @@ config USB_XHCI_TEGRA
>  	  Say 'Y' to enable the support for the xHCI host controller
>  	  found in NVIDIA Tegra124 and later SoCs.
>  
> +config USB_OHCI_BRCM
> +       tristate

This symbol is not used any more.

> +
> +config USB_EHCI_BRCM
> +       tristate
> +
> +config USB_XHCI_BRCM
> +       tristate
> +
> +config BRCM_USB_PHY
> +       tristate
> +
> +config USB_BRCM
> +	tristate "Broadcom STB USB support"
> +	depends on ARCH_BRCMSTB
> +	select USB_OHCI_HCD_PLATFORM if USB_OHCI_HCD
> +	select USB_EHCI_BRCM if USB_EHCI_HCD
> +	select USB_XHCI_BRCM if USB_XHCI_HCD
> +	select USB_XHCI_PLATFORM if USB_XHCI_HCD
> +	select BRCM_USB_PHY if USB_OHCI_HCD || USB_EHCI_HCD || USB_XHCI_HCD
> +	select GENERIC_PHY if BRCM_USB_PHY
> +	default ARCH_BRCMSTB
> +	help
> +	  Say Y to enable support for XHCI, EHCI and OHCI host controllers
> +	  found in Broadcom STB SoC's.
> +
> +	  Disabling this will keep the controllers and corresponding
> +	  PHYs powered down.
> +
>  endif # USB_XHCI_HCD
>  
>  config USB_EHCI_HCD

Alan Stern