linux-kernel - Re: [PATCH v2 1/4] nfc: pn533: add UART phy driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <6CB47B97-F58D-4162-98C1-8C8C88CE2914@holtmann.org>
Date:   Thu, 18 Oct 2018 17:00:28 +0200
From:   Marcel Holtmann <marcel@...tmann.org>
To:     Lars Poeschel <poeschel@...onage.de>
Cc:     devicetree@...r.kernel.org, Samuel Ortiz <sameo@...ux.intel.com>,
        open list <linux-kernel@...r.kernel.org>,
        "open list:NFC SUBSYSTEM" <linux-wireless@...r.kernel.org>
Subject: Re: [PATCH v2 1/4] nfc: pn533: add UART phy driver

Hi Lars,

> This adds the UART phy interface for the pn533 driver.
> The pn533 driver can be used through UART interface this way.
> It is implemented as a serdev device.
> 
> Signed-off-by: Lars Poeschel <poeschel@...onage.de>
> ---
> Changes in v2:
> - switched from tty line discipline to serdev, resulting in many
>  simplifications
> - SPDX License Identifier
> 
> drivers/nfc/pn533/Kconfig  |  10 ++
> drivers/nfc/pn533/Makefile |   2 +
> drivers/nfc/pn533/pn533.h  |   8 ++
> drivers/nfc/pn533/uart.c   | 283 +++++++++++++++++++++++++++++++++++++
> 4 files changed, 303 insertions(+)
> create mode 100644 drivers/nfc/pn533/uart.c
> 
> diff --git a/drivers/nfc/pn533/Kconfig b/drivers/nfc/pn533/Kconfig
> index d94122dd30e4..da3ea2dbaa8a 100644
> --- a/drivers/nfc/pn533/Kconfig
> +++ b/drivers/nfc/pn533/Kconfig
> @@ -25,3 +25,13 @@ config NFC_PN533_I2C
> 
> 	  If you choose to build a module, it'll be called pn533_i2c.
> 	  Say N if unsure.
> +
> +config NFC_PN532_UART
> +	tristate "NFC PN532 device support (UART)”

you are missing the "depends on SERIAL_DEV_BUS” here.

> +	select NFC_PN533
> +	---help---
> +	  This module adds support for the NXP pn532 UART interface.
> +	  Select this if your platform is using the UART bus.
> +
> +	  If you choose to build a module, it'll be called pn532_uart.
> +	  Say N if unsure.

Regards

Marcel