linux-kernel - Re: [PATCH] pstore: Refactor compression initialization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <10d9618bf794d6e07b537455344b30238d5f4e80.camel@perches.com>
Date:   Thu, 18 Oct 2018 10:14:19 -0700
From:   Joe Perches <joe@...ches.com>
To:     Kees Cook <keescook@...omium.org>,
        Joel Fernandes <joel@...lfernandes.org>,
        Sai Prakash Ranjan <saiprakash.ranjan@...eaurora.org>
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH] pstore: Refactor compression initialization

On Wed, 2018-10-17 at 14:41 -0700, Kees Cook wrote:
> With compression initialization now separated from pstore_register(),
> there is no longer a good reason to do compression method selection
> during fs init. Instead, merge everything together into the late init.
> Additionally cleans up the reporting to be more clear.
[]
> diff --git a/fs/pstore/platform.c b/fs/pstore/platform.c
[]
> @@ -274,36 +274,56 @@ static int pstore_decompress(void *in, void *out,
[]
> -	big_oops_buf = kmalloc(big_oops_buf_sz, GFP_KERNEL);
> -	if (!big_oops_buf) {
> -		pr_err("allocate compression buffer error!\n");
> +	buf = kmalloc(size, GFP_KERNEL);
> +	if (!buf) {
> +		pr_err("Failed %d byte compression buffer allocation for: %s\n",
> +		       size, zbackend->name);

Given that there is a generic OOM message emitted on
kmalloc failures, rather than expanding the unnecessary
alloc failure message, how about just deleting it instead?