linux-kernel - Re: [PATCH] PCI: pcie: remove redundant 'default n' from Kconfig

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20181018190926.GJ5906@bhelgaas-glaptop.roam.corp.google.com>
Date:   Thu, 18 Oct 2018 14:09:26 -0500
From:   Bjorn Helgaas <helgaas@...nel.org>
To:     Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>
Cc:     Bjorn Helgaas <bhelgaas@...gle.com>, linux-pci@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] PCI: pcie: remove redundant 'default n' from Kconfig

On Tue, Oct 16, 2018 at 04:38:13PM +0200, Bartlomiej Zolnierkiewicz wrote:
> 'default n' is the default value for any bool or tristate Kconfig
> setting so there is no need to write it explicitly.
> 
> Also since commit f467c5640c29 ("kconfig: only write '# CONFIG_FOO
> is not set' for visible symbols") the Kconfig behavior is the same
> regardless of 'default n' being present or not:
> 
>     ...
>     One side effect of (and the main motivation for) this change is making
>     the following two definitions behave exactly the same:
>     
>         config FOO
>                 bool
>     
>         config FOO
>                 bool
>                 default n
>     
>     With this change, neither of these will generate a
>     '# CONFIG_FOO is not set' line (assuming FOO isn't selected/implied).
>     That might make it clearer to people that a bare 'default n' is
>     redundant.
>     ...
> 
> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>

Applied to pci/misc for v4.20, thanks!

> ---
>  drivers/pci/pcie/Kconfig |    4 ----
>  1 file changed, 4 deletions(-)
> 
> Index: b/drivers/pci/pcie/Kconfig
> ===================================================================
> --- a/drivers/pci/pcie/Kconfig	2018-10-09 15:58:49.831123212 +0200
> +++ b/drivers/pci/pcie/Kconfig	2018-10-16 16:36:32.419732670 +0200
> @@ -36,7 +36,6 @@ config PCIEAER
>  config PCIEAER_INJECT
>  	tristate "PCI Express error injection support"
>  	depends on PCIEAER && DYNAMIC_FTRACE_WITH_REGS
> -	default n
>  	help
>  	  This enables PCI Express Root Port Advanced Error Reporting
>  	  (AER) software error injector.
> @@ -84,7 +83,6 @@ config PCIEASPM
>  config PCIEASPM_DEBUG
>  	bool "Debug PCI Express ASPM"
>  	depends on PCIEASPM
> -	default n
>  	help
>  	  This enables PCI Express ASPM debug support. It will add per-device
>  	  interface to control ASPM.
> @@ -129,7 +127,6 @@ config PCIE_PME
>  config PCIE_DPC
>  	bool "PCI Express Downstream Port Containment support"
>  	depends on PCIEPORTBUS && PCIEAER
> -	default n
>  	help
>  	  This enables PCI Express Downstream Port Containment (DPC)
>  	  driver support.  DPC events from Root and Downstream ports
> @@ -139,7 +136,6 @@ config PCIE_DPC
>  
>  config PCIE_PTM
>  	bool "PCI Express Precision Time Measurement support"
> -	default n
>  	depends on PCIEPORTBUS
>  	help
>  	  This enables PCI Express Precision Time Measurement (PTM)