linux-kernel - Re: [PATCH] clk: fixed-rate: fix of_node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <153989416422.53599.5865157270835783532@swboyd.mtv.corp.google.com>
Date:   Thu, 18 Oct 2018 13:22:44 -0700
From:   Stephen Boyd <sboyd@...nel.org>
To:     Alan Tull <atull@...nel.org>,
        Michael Turquette <mturquette@...libre.com>
Cc:     Ricardo Ribalda Delgado <ricardo.ribalda@...il.com>,
        Alan Tull <atull@...nel.org>, linux-clk@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] clk: fixed-rate: fix of_node_get-put imbalance

Quoting Alan Tull (2018-10-18 12:54:11)
> When the fixed rate clock is created by devicetree,
> of_clk_add_provider is called.  Add a call to
> of_clk_del_provider in the remove function to balance
> it out.
> 
> Signed-off-by: Alan Tull <atull@...nel.org>
> ---

Fixes tag? I'll tack one on.

>  drivers/clk/clk-fixed-rate.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/clk/clk-fixed-rate.c b/drivers/clk/clk-fixed-rate.c
> index b5c46b3f8764..6d6475c32ee5 100644
> --- a/drivers/clk/clk-fixed-rate.c
> +++ b/drivers/clk/clk-fixed-rate.c
> @@ -200,6 +200,7 @@ static int of_fixed_clk_remove(struct platform_device *pdev)
>  {
>         struct clk *clk = platform_get_drvdata(pdev);
>  
> +       of_clk_del_provider(pdev->dev.of_node);
>         clk_unregister_fixed_rate(clk);
>  
>         return 0;