linux-kernel - Re: [PATCH v5 8/8] clk: fixed-rate: Convert into a module platform driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <153989424794.53599.4926915592056818669@swboyd.mtv.corp.google.com>
Date:   Thu, 18 Oct 2018 13:24:07 -0700
From:   Stephen Boyd <sboyd@...nel.org>
To:     Alan Tull <atull@...nel.org>,
        Ricardo Ribalda Delgado <ricardo.ribalda@...il.com>
Cc:     mturquette@...libre.com, sboyd@...eaurora.org,
        Sascha Hauer <s.hauer@...gutronix.de>,
        linux-clk@...r.kernel.org,
        linux-kernel <linux-kernel@...r.kernel.org>,
        Frank Rowand <frowand.list@...il.com>
Subject: Re: [PATCH v5 8/8] clk: fixed-rate: Convert into a module platform driver

Quoting Alan Tull (2018-10-18 12:20:58)
> On Tue, Jul 5, 2016 at 11:45 AM Ricardo Ribalda Delgado
> <ricardo.ribalda@...il.com> wrote:
> 
> I've stumbled across a of_node_get/put imbalance that happens when the
> fixed rate clock is added and deleted using device tree.  The cause is
> that this driver calls of_clk_add_provider() when probed, but doesn't
> call of_clk_del_provider() when removed.
> 
> It looks like a lot of clock drivers share that issue:
> 
> $ cd drivers/clk/
> $ git grep -l of_clk_add_provider * | xargs grep -L of_clk_del_provider | wc -l
> 131
> 
> It should be a one line fix, but for many files.
> 
> I'm not a clock subsystem expert, so please let me know whether I'm
> missing something here.
> 

Patches welcome. Please include Fixes: tags for backports. Probably
drivers don't care because clk devices are almost never removed. That
isn't to say it shouldn't be fixed, but just giving some background on
why nobody has fixed it.