linux-kernel - Re: [PATCH 4/8] PCI: consolidate PCI config entry in drivers/pci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181019070224.GB30556@lst.de>
Date:   Fri, 19 Oct 2018 09:02:24 +0200
From:   Christoph Hellwig <hch@....de>
To:     Masahiro Yamada <yamada.masahiro@...ionext.com>
Cc:     Christoph Hellwig <hch@....de>, linux-pci@...r.kernel.org,
        mporter@...nel.crashing.org, Alex Bounine <alex.bou9@...il.com>,
        Dominik Brodowski <linux@...inikbrodowski.net>,
        Linux Kbuild mailing list <linux-kbuild@...r.kernel.org>,
        linux-scsi <linux-scsi@...r.kernel.org>,
        linux-arch <linux-arch@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linuxppc-dev <linuxppc-dev@...ts.ozlabs.org>
Subject: Re: [PATCH 4/8] PCI: consolidate PCI config entry in drivers/pci

On Fri, Oct 19, 2018 at 02:07:04PM +0900, Masahiro Yamada wrote:
> We could add 'depends on HAVE_PCI' or something
> to guard it to avoid changing the logic.

I guess that makes sense.

> config PCI_ENDPOINT
>         bool "PCI Endpoint Support"
>         depends on HAVE_PCI     # Is this correct ??
>         depends on HAS_DMA
> 
> 
> or better to have 'depends on PCI' ?

It does not depend on the normal PCI support, so I don't think this
is the right thing to do.