linux-kernel - Re: [PATCH] memblock: remove stale #else and the code it protects

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181019081729.klvckcytnhheaian@master>
Date:   Fri, 19 Oct 2018 08:17:30 +0000
From:   Wei Yang <richard.weiyang@...il.com>
To:     Mike Rapoport <rppt@...ux.vnet.ibm.com>
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        Alexander Duyck <alexander.duyck@...il.com>,
        Michal Hocko <mhocko@...e.com>, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] memblock: remove stale #else and the code it protects

Which tree it applies?

On Thu, Sep 27, 2018 at 08:03:45PM +0300, Mike Rapoport wrote:
>During removal of HAVE_MEMBLOCK definition, the #else clause of the
>
>	#ifdef CONFIG_HAVE_MEMBLOCK
>		...
>	#else
>		...
>	#endif
>
>conditional was not removed.
>
>Remove it now.
>
>Signed-off-by: Mike Rapoport <rppt@...ux.vnet.ibm.com>
>Reported-by: Alexander Duyck <alexander.duyck@...il.com>
>Cc: Michal Hocko <mhocko@...e.com>
>---
> include/linux/memblock.h | 5 -----
> 1 file changed, 5 deletions(-)
>
>diff --git a/include/linux/memblock.h b/include/linux/memblock.h
>index d3bc270..d4d0e01 100644
>--- a/include/linux/memblock.h
>+++ b/include/linux/memblock.h
>@@ -597,11 +597,6 @@ static inline void early_memtest(phys_addr_t start, phys_addr_t end)
> {
> }
> #endif
>-#else
>-static inline phys_addr_t memblock_alloc(phys_addr_t size, phys_addr_t align)
>-{
>-	return 0;
>-}
> 
> #endif /* __KERNEL__ */
> 
>-- 
>2.7.4

-- 
Wei Yang
Help you, Help me