linux-kernel - Re: [PATCH V2] perf arm64: Fix generate system call table failed with /tmp mounted with noexec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9da3ccbf-ec36-c676-7472-fe7d642cd7e0@gydle.com>
Date:   Fri, 19 Oct 2018 11:22:38 -0400
From:   Sébastien Boisvert <sboisvert@...le.com>
To:     Hongxu Jia <hongxu.jia@...driver.com>,
        linux-kernel@...r.kernel.org, linux-perf-users@...r.kernel.org
Cc:     kim.phillips@....com, brueckner@...ux.ibm.com,
        alexander.shishkin@...ux.intel.com, jolsa@...hat.com,
        mpe@...erman.id.au, peterz@...radead.org,
        ravi.bangoria@...ux.vnet.ibm.com, tmricht@...ux.vnet.ibm.com,
        acme@...hat.com, namhyung@...nel.org
Subject: Re: [PATCH V2] perf arm64: Fix generate system call table failed with
 /tmp mounted with noexec



On 2018-10-18 10:16 p.m., Hongxu Jia wrote:
> When /tmp is mounted with noexec, mksyscalltbl fails.
> [snip]
> |perf-1.0/tools/perf/arch/arm64/entry/syscalls//mksyscalltbl:
> /tmp/create-table-6VGPSt: Permission denied
> [snip]
> 
> Add variable TMPDIR as prefix dir of the temporary file, if it is set,
> replace default /tmp
> 
> Remove extra slash from `syscalls//mksyscalltbl'
> 
> Fixes: 2b5882435606 ("perf arm64: Generate system call table from asm/unistd.h")
> 
> Signed-off-by: Hongxu Jia <hongxu.jia@...driver.com>
> ---
>  tools/perf/arch/arm64/Makefile                    | 2 +-
>  tools/perf/arch/arm64/entry/syscalls/mksyscalltbl | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/perf/arch/arm64/Makefile b/tools/perf/arch/arm64/Makefile
> index dbef716..bc2a284 100644
> --- a/tools/perf/arch/arm64/Makefile
> +++ b/tools/perf/arch/arm64/Makefile
> @@ -13,7 +13,7 @@ out    := $(OUTPUT)arch/arm64/include/generated/asm
>  header := $(out)/syscalls.c
>  incpath := $(srctree)/tools
>  sysdef := $(srctree)/tools/arch/arm64/include/uapi/asm/unistd.h
> -sysprf := $(srctree)/tools/perf/arch/arm64/entry/syscalls/
> +sysprf := $(srctree)/tools/perf/arch/arm64/entry/syscalls

Should this appear in different patch, since it is unrelated to adding TMPDIR support ?

Thanks

>  systbl := $(sysprf)/mksyscalltbl
>  
>  # Create output directory if not already present
> diff --git a/tools/perf/arch/arm64/entry/syscalls/mksyscalltbl b/tools/perf/arch/arm64/entry/syscalls/mksyscalltbl
> index 2dbb8cad..c88fd32 100755
> --- a/tools/perf/arch/arm64/entry/syscalls/mksyscalltbl
> +++ b/tools/perf/arch/arm64/entry/syscalls/mksyscalltbl
> @@ -23,7 +23,7 @@ create_table_from_c()
>  {
>  	local sc nr last_sc
>  
> -	create_table_exe=`mktemp /tmp/create-table-XXXXXX`
> +	create_table_exe=`mktemp ${TMPDIR:-/tmp}/create-table-XXXXXX`
>  
>  	{
>  
>