linux-kernel - Re: [PATCH] pstore: Fix annotation on declaration of pstore_exit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAGXu5jKtfNDwygALbkwusMH+ann55FV5tjOTw3zFNFRjb379jw@mail.gmail.com>
Date:   Fri, 19 Oct 2018 11:41:50 -0700
From:   Kees Cook <keescook@...omium.org>
To:     Nathan Chancellor <natechancellor@...il.com>
Cc:     Anton Vorontsov <anton@...msg.org>,
        Colin Cross <ccross@...roid.com>,
        Tony Luck <tony.luck@...el.com>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] pstore: Fix annotation on declaration of pstore_exit_fs

On Fri, Oct 19, 2018 at 11:37 AM, Nathan Chancellor
<natechancellor@...il.com> wrote:
> Clang warns (trimmed for brevity):
>
> fs/pstore/inode.c:504:6: error: section does not match previous
> declaration [-Werror,-Wsection]
> void __exit pstore_exit_fs(void)
>      ^
> fs/pstore/internal.h:42:6: note: previous attribute is here
> void __init     pstore_exit_fs(void);
>      ^
>
> Fixes: a4fb3d2fefd2 ("pstore: Centralize init/exit routines")
> Signed-off-by: Nathan Chancellor <natechancellor@...il.com>
> ---
>  fs/pstore/internal.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/pstore/internal.h b/fs/pstore/internal.h
> index 98bb4fa6e6a7..7062ea4bc57c 100644
> --- a/fs/pstore/internal.h
> +++ b/fs/pstore/internal.h
> @@ -39,6 +39,6 @@ extern void   pstore_record_init(struct pstore_record *record,
>
>  /* Called during pstore init/exit. */
>  int __init     pstore_init_fs(void);
> -void __init    pstore_exit_fs(void);
> +void __exit    pstore_exit_fs(void);

Whoops! Thanks, I'll fold this fix into the patch.

-Kees

>
>  #endif
> --
> 2.19.1
>



-- 
Kees Cook
Pixel Security