linux-kernel - Re: [PATCH] reiserfs: remove workaround code for GCC 3.x

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c5b98062-9646-a1ba-12df-2b1e3dbebe5b@suse.com>
Date:   Fri, 19 Oct 2018 17:59:53 -0400
From:   Jeff Mahoney <jeffm@...e.com>
To:     Masahiro Yamada <yamada.masahiro@...ionext.com>,
        reiserfs-devel@...r.kernel.org
Cc:     Benjamin Herrenschmidt <benh@...nel.crashing.org>,
        Paul Mackerras <paulus@...ba.org>,
        Michael Ellerman <mpe@...erman.id.au>,
        linux-kernel@...r.kernel.org, Thomas Gleixner <tglx@...utronix.de>,
        Philippe Ombredanne <pombredanne@...b.com>,
        Kate Stewart <kstewart@...uxfoundation.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [PATCH] reiserfs: remove workaround code for GCC 3.x

On 8/26/18 10:33 PM, Masahiro Yamada wrote:
> Commit cafa0010cd51 ("Raise the minimum required gcc version to 4.6")
> bumped the minimum GCC version to 4.6 for all architectures.
> 
> The workaround code in fs/reiserfs/Makefile is obsolete now.
> 
> Signed-off-by: Masahiro Yamada <yamada.masahiro@...ionext.com>

Acked-by: Jeff Mahoney <jeffm@...e.com>

Thanks,

-Jeff

> ---
> 
>  fs/reiserfs/Makefile | 9 ---------
>  1 file changed, 9 deletions(-)
> 
> diff --git a/fs/reiserfs/Makefile b/fs/reiserfs/Makefile
> index a39a562..bd29c58 100644
> --- a/fs/reiserfs/Makefile
> +++ b/fs/reiserfs/Makefile
> @@ -26,14 +26,5 @@ ifeq ($(CONFIG_REISERFS_FS_POSIX_ACL),y)
>  reiserfs-objs += xattr_acl.o
>  endif
>  
> -# gcc -O2 (the kernel default)  is overaggressive on ppc32 when many inline
> -# functions are used.  This causes the compiler to advance the stack
> -# pointer out of the available stack space, corrupting kernel space,
> -# and causing a panic. Since this behavior only affects ppc32, this ifeq
> -# will work around it. If any other architecture displays this behavior,
> -# add it here.
> -ccflags-$(CONFIG_PPC32) := $(call cc-ifversion, -lt, 0400, -O1)
> -
>  TAGS:
>  	etags *.c
> -
> 

-- 
Jeff Mahoney
SUSE Labs




Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)