linux-kernel - [PATCH] jffs2: ensure wbuf_verify is valid before using it.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 20 Oct 2018 20:08:49 +0800
From:   Hou Tao <houtao1@...wei.com>
To:     <linux-mtd@...ts.infradead.org>, <dwmw2@...radead.org>
CC:     <linux-kernel@...r.kernel.org>, <stable@...r.kernel.org>,
        <richard.weinberger@...il.com>, <boris.brezillon@...tlin.com>
Subject: [PATCH] jffs2: ensure wbuf_verify is valid before using it.

Now MTD emulated by UBI volumn doesn't allocate wbuf_verify in
jffs2_ubivol_setup(), because UBI can do the verifcation itself,
so when CONFIG_JFFS2_FS_WBUF_VERIFY is enabled and a MTD device
emulated by UBI volumn is used, a Oops will occur as show in the
following trace:

    general protection fault: 0000 [#1] SMP KASAN PTI
    CPU: 6 PID: 404 Comm: kworker/6:1 Not tainted 4.19.0-rc8
    Workqueue: events_long delayed_wbuf_sync
    RIP: 0010:ubi_io_read+0x156/0x650
    Call Trace:
     ubi_eba_read_leb+0x57d/0xba0
     ubi_leb_read+0xe5/0x1b0
     gluebi_read+0x10c/0x1a0
     mtd_read+0x112/0x340
     jffs2_verify_write+0xef/0x440
     __jffs2_flush_wbuf+0x3fa/0x3540
     jffs2_flush_wbuf_gc+0x1b1/0x2e0
     process_one_work+0x58b/0x11e0
     worker_thread+0x8f/0xfe0
     kthread+0x2ae/0x3a0
     ret_from_fork+0x35/0x40

Fix the problem by checking the validity of wbuf_verify before
using it in jffs2_verify_write().

Cc: stable@...r.kernel.org
Fixes: 0029da3bf430 ("JFFS2: add UBI support")
Signed-off-by: Hou Tao <houtao1@...wei.com>
---
 fs/jffs2/wbuf.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/fs/jffs2/wbuf.c b/fs/jffs2/wbuf.c
index c6821a509481..3de45f4559d1 100644
--- a/fs/jffs2/wbuf.c
+++ b/fs/jffs2/wbuf.c
@@ -234,6 +234,13 @@ static int jffs2_verify_write(struct jffs2_sb_info *c, unsigned char *buf,
 	size_t retlen;
 	char *eccstr;
 
+	/*
+	 * MTD emulated by UBI volume doesn't allocate wbuf_verify,
+	 * because it can do the verification itself.
+	 */
+	if (!c->wbuf_verify)
+		return 0;
+
 	ret = mtd_read(c->mtd, ofs, c->wbuf_pagesize, &retlen, c->wbuf_verify);
 	if (ret && ret != -EUCLEAN && ret != -EBADMSG) {
 		pr_warn("%s(): Read back of page at %08x failed: %d\n",
-- 
2.16.2.dirty