linux-kernel - Re: [PATCH] block: don't check position contiguity for DISCARD in attempt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <09103f89-35af-e4e5-fd7c-e3f48e6fda75@oracle.com>
Date:   Sat, 20 Oct 2018 21:57:44 +0800
From:   "jianchao.wang" <jianchao.w.wang@...cle.com>
To:     "Martin K. Petersen" <martin.petersen@...cle.com>
Cc:     axboe@...nel.dk, linux-block@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] block: don't check position contiguity for DISCARD in
 attempt_merge

Hi Martin

On 10/19/18 11:57 PM, Martin K. Petersen wrote:
> 
> Jianchao,
> 
>> Discard command supports multiple ranges of blocks, so needn't
>> checking position contiguity when merging. Let's do the same thing
>> in attempt_merge as the blk_try_merge.
> 
> Discards need to be contiguous unless queue->limits.max_discard_segments
> is bigger than 1. So if you remove this I think you need to add a
> contiguity check in req_attempt_discard_merge().
> 
Yes.

I will send the V2 version next.

Thanks
Jianchao