linux-kernel - Re: [PATCH 2/2] usb: xhci: fix timeout for transition from RExit to U0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181021182128.GA6485@kroah.com>
Date:   Sun, 21 Oct 2018 19:21:28 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Aaron Ma <aaron.ma@...onical.com>
Cc:     mathias.nyman@...el.com, linux-usb@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] usb: xhci: fix timeout for transition from RExit to
 U0

On Mon, Oct 22, 2018 at 01:08:45AM +0800, Aaron Ma wrote:
> This definition is used by msecs_to_jiffies in milliseconds.
> According to the comments, max rexit timeout should be 20ms.
> Align with the comments to properly calculate the delay.
> 
> Verified on Sunrise Point-LP and Cannon Lake.
> 
> Signed-off-by: Aaron Ma <aaron.ma@...onical.com>
> ---
>  drivers/usb/host/xhci.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/host/xhci.h b/drivers/usb/host/xhci.h
> index 6230a578324c..30225c53be1c 100644
> --- a/drivers/usb/host/xhci.h
> +++ b/drivers/usb/host/xhci.h
> @@ -1678,7 +1678,7 @@ struct xhci_bus_state {
>   * It can take up to 20 ms to transition from RExit to U0 on the
>   * Intel Lynx Point LP xHCI host.
>   */
> -#define	XHCI_MAX_REXIT_TIMEOUT	(20 * 1000)
> +#define	XHCI_MAX_REXIT_TIMEOUT	20

Can we put the units in the #define itself so that this will be more
obvious in the future?  Like XHCI_MAX_REXIT_TIMEOUT_MS?

thanks,

greg k-h