linux-kernel - Re: [PATCH] power: max8925: mark expected switch fall-through

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20181021193413.6w7x4rvx4xkyeyaw@earth.universe>
Date:   Sun, 21 Oct 2018 21:34:13 +0200
From:   Sebastian Reichel <sre@...nel.org>
To:     "Gustavo A. R. Silva" <gustavo@...eddedor.com>
Cc:     linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] power: max8925: mark expected switch fall-through

Hi,

On Thu, Oct 04, 2018 at 03:56:36PM +0200, Gustavo A. R. Silva wrote:
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
> 
> Addresses-Coverity-ID: 201510 ("Missing break in switch")
> Signed-off-by: Gustavo A. R. Silva <gustavo@...eddedor.com>
> ---

Thanks, queued.

-- Sebastian

>  drivers/power/supply/max8925_power.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/power/supply/max8925_power.c b/drivers/power/supply/max8925_power.c
> index 3b94620..39b4d5b 100644
> --- a/drivers/power/supply/max8925_power.c
> +++ b/drivers/power/supply/max8925_power.c
> @@ -124,6 +124,7 @@ static irqreturn_t max8925_charger_handler(int irq, void *data)
>  	case MAX8925_IRQ_VCHG_THM_OK_F:
>  		/* Battery is not ready yet */
>  		dev_dbg(chip->dev, "Battery temperature is out of range\n");
> +		/* Fall through */
>  	case MAX8925_IRQ_VCHG_DC_OVP:
>  		dev_dbg(chip->dev, "Error detection\n");
>  		__set_charger(info, 0);
> -- 
> 2.7.4
> 

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)