linux-kernel - Re: [PATCH 1/2] perf script: allow extended console debug output

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181022094033.GF2452@krava>
Date:   Mon, 22 Oct 2018 11:40:33 +0200
From:   Jiri Olsa <jolsa@...hat.com>
To:     Milian Wolff <milian.wolff@...b.com>
Cc:     acme@...nel.org, jolsa@...nel.org, Linux-kernel@...r.kernel.org,
        linux-perf-users@...r.kernel.org
Subject: Re: [PATCH 1/2] perf script: allow extended console debug output

On Sun, Oct 21, 2018 at 09:14:23PM +0200, Milian Wolff wrote:
> The script tool isn't using a browser, yet use_browser
> wasn't set explicitly to zero. This in turn lead to confusing
> output such as:
> 
> ```
> $ perf script -vvv ...
> ...
> overlapping maps in /home/milian/foobar (disable tui for more info)
> ...
> ```
> 
> Explicitly set use_browser to 0 now, which gives us the extended
> debug information now in perf script as expected.
> 
> Signed-off-by: Milian Wolff <milian.wolff@...b.com>
> Cc: Arnaldo Carvalho de Melo <acme@...nel.org>

Acked-by: Jiri Olsa <jolsa@...hat.com>

thanks,
jirka

> ---
>  tools/perf/builtin-script.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/perf/builtin-script.c b/tools/perf/builtin-script.c
> index 4da5e32b9e03..bd468b90801b 100644
> --- a/tools/perf/builtin-script.c
> +++ b/tools/perf/builtin-script.c
> @@ -3417,8 +3417,10 @@ int cmd_script(int argc, const char **argv)
>  		exit(-1);
>  	}
>  
> -	if (!script_name)
> +	if (!script_name) {
>  		setup_pager();
> +		use_browser = 0;
> +	}
>  
>  	session = perf_session__new(&data, false, &script.tool);
>  	if (session == NULL)
> -- 
> 2.19.1