Message-ID: <781B64F4-99AA-4771-B1E7-5B71896D4006@cs.rutgers.edu>
Date:   Mon, 22 Oct 2018 10:00:53 -0400
From:   "Zi Yan" <zi.yan@...rutgers.edu>
To:     "Andrea Arcangeli" <aarcange@...hat.com>
Cc:     "Anshuman Khandual" <anshuman.khandual@....com>,
        linux-mm@...ck.org, linux-kernel@...r.kernel.org,
        kirill.shutemov@...ux.intel.com, akpm@...ux-foundation.org,
        mhocko@...e.com, will.deacon@....com,
        "Naoya Horiguchi" <n-horiguchi@...jp.nec.com>
Subject: Re: [PATCH] mm/thp: Correctly differentiate between mapped THP and
 PMD migration entry

Hi Andrea,

On 16 Oct 2018, at 22:09, Andrea Arcangeli wrote:

> Hello Zi,
>
> On Sun, Oct 14, 2018 at 08:53:55PM -0400, Zi Yan wrote:
>> Hi Andrea, what is the purpose/benefit of making x86’s pmd_present() returns true
>> for a THP under splitting? Does it cause problems when ARM64’s pmd_present()
>> returns false in the same situation?
>
> !pmd_present means it's a migration entry or swap entry and doesn't
> point to RAM. It means if you do pmd_to_page(*pmd) it will return you
> an undefined result.
>
> During splitting the physical page is still very well pointed by the
> pmd as long as pmd_trans_huge returns true and you hold the
> pmd_lock.
>
> pmd_trans_huge must be true at all times for a transhuge pmd that
> points to a hugepage, or all VM fast paths won't serialize with the
> pmd_lock, that is the only reason why, and it's a very good reason
> because it avoids to take the pmd_lock when walking over non transhuge
> pmds (i.e. when there are no THP allocated).
>
> Now if we've to keep _PAGE_PSE set and return true in pmd_trans_huge
> at all times, why would you want to make pmd_present return false? How
> could it help if pmd_trans_huge returns true, but pmd_present returns
> false despite pmd_to_page works fine and the pmd is really still
> pointing to the page?
>
> When userland faults on such pmd !pmd_present it will make the page
> fault take a swap or migration path, but that's the wrong path if the
> pmd points to RAM.
>
> What we need to do during split is an invalidate of the huge TLB.
> There's no pmd_trans_splitting anymore, so we only clear the present
> bit in the PTE despite pmd_present still returns true (just like
> PROT_NONE, nothing new in this respect). pmd_present never meant the
> real present bit in the pte was set, it just means the pmd points to
> RAM. It means it doesn't point to swap or migration entry and you can
> do pmd_to_page and it works fine.
>
> We need to invalidate the TLB by clearing the present bit and by
> flushing the TLB before overwriting the transhuge pmd with the regular
> pte (i.e. to make it non huge). That is actually required by an errata
> (l1 cache aliasing of the same mapping through two different TLB of
> two different sizes broke some old CPU and triggered machine checks).
> It's not something fundamentally necessary from a common code point of
> view. It's more risky from an hardware (not software) standpoint and
> before you can get rid of the pmd you need to do a TLB flush anyway to
> be sure CPUs stops using it, so better clear the present bit before
> doing the real costly thing (the tlb flush with IPIs). Clearing the
> present bit during the TLB flush is a cost that gets lost in the noise.
>
> The clear of the real present bit during pmd (virtual) splitting is
> done with pmdp_invalidate, that is created specifically to keeps
> pmd_trans_huge=true, pmd_present=true despite the present bit is not
> set. So you could imagine _PAGE_PSE as the real present bit.
>
> Before the physical split was deferred and decoupled from the virtual
> memory pmd split, pmd_trans_splitting allowed to wait the split to
> finish and to keep all gup_fast at bay during it (while the page was
> still mapped readable and writable in userland by other CPUs). Now the
> physical split is deferred so you just split the pmd locally and only
> a physical split invoked on the page (not the virtual split invoked on
> the pmd with split_huge_pmd) has to keep gup at bay, and it does so by
> freezing the refcount so all gup_fast fail with the
> page_cache_get_speculative during the freeze. This removed the need of
> the pmd_splitting flag in gup_fast (when pmd_splitting was set gup
> fast had to go through the non-fast gup), but it means that now a
> hugepage cannot be physically splitted if it's gup pinned. The main
> difference is that freezing the refcount can fail, so the code must
> learn to cope with such failure and defer it. Decoupling the physical
> and virtual splits introduced the need of tracking the doublemap case
> with a new PG_double_map flag too. It makes the refcounting of
> hugepages trivial in comparison (identical to hugetlbfs in fact), but
> it requires total_mapcount to account for all those huge and non huge
> mappings. It primarily pays off to add THP to tmpfs where the physical
> split may have to be deferred for pagecache reasons anyway.

Thanks for your detailed explanation!

Do you think it is worth documenting what you have said? At least on
why we want pmd_present() and pmd_trans_huge() both return true when
a THP is under splitting, so that we can avoid some confusion in the future.
I can send a patch to add it to Document/vm/transhuge.rst.

--
Best Regards
Yan Zi

Download attachment "signature.asc" of type "application/pgp-signature" (558 bytes)

Powered by blists - more mailing lists