linux-kernel - Re: [PATCH 0/2] tracing: Fix synthetic event parser

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1540239293.4393.6.camel@kernel.org>
Date:   Mon, 22 Oct 2018 15:14:53 -0500
From:   Tom Zanussi <zanussi@...nel.org>
To:     Masami Hiramatsu <mhiramat@...nel.org>,
        Steven Rostedt <rostedt@...dmis.org>,
        Shuah Khan <shuah@...nel.org>
Cc:     Rajvi Jingar <rajvi.jingar@...el.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/2] tracing: Fix synthetic event parser

Hi Masami,

On Mon, 2018-10-22 at 00:07 +0900, Masami Hiramatsu wrote:
> Hi,
> 
> I found another bug in synthetic event. This is a small fix, but
> confusingly, there is also a bug in a test case.
> 
> Steve, since the testcase bugfix ([2/2]) breaks the test result
> unless corresponding fix ([1/2]), I would like to ask you to send
> these fixes from your tree.
> Shuah, could you give this your ack?
> 

Yes, I think the silent failing mode is confusing to users, and so
these changes make more sense.

Acked-by: Tom Zanussi <zanussi@...ux.intel.com>
Tested-by: Tom Zanussi <zanussi@...ux.intel.com>

Thanks,

Tom


> Thank you,
> 
> ---
> 
> Masami Hiramatsu (2):
>       tracing: Return -ENOENT if there is no target synthetic event
>       selftests/ftrace: Fix synthetic event test to delete event
> correctly
> 
> 
>  kernel/trace/trace_events_hist.c                   |    4 +++-
>  .../trigger-synthetic-event-createremove.tc        |   12 ++++++--
> ----
>  2 files changed, 9 insertions(+), 7 deletions(-)
> 
> --
> Masami Hiramatsu (Linaro) <mhiramat@...nel.org>