linux-kernel - Re: [Ksummit-discuss] Call to Action Re: [PATCH 0/7] Code of Conduct: Fix some wording, and add an interpretation document

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 22 Oct 2018 18:46:04 -0400
From:   "Theodore Y. Ts'o" <tytso@....edu>
To:     NeilBrown <neil@...wn.name>
Cc:     Josh Triplett <josh@...htriplett.org>,
        Mishi Choudhary <mishi@...ux.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        ksummit-discuss@...ts.linuxfoundation.org
Subject: Re: [Ksummit-discuss] Call to Action Re: [PATCH 0/7] Code of
 Conduct: Fix some wording, and add an interpretation document

Neil,

I disagree with your framing, and thus your analysis, and thus your
proposed solution.

On Tue, Oct 23, 2018 at 07:26:06AM +1100, NeilBrown wrote:
> If, for example, Linus or Andrew said "if you cannot work with any given
> maintainer, I will consider your patch directly, but you need to point
> to where you tried, and why you failed - or to where the promise is
> inadequate".
> 
> Currently if a maintainer is rude to you, there is no where else that
> you can go and *that* is why it hurts.  It isn't the abuse so much as
> the powerlessness associated with it.  If you can (metaphorically) say
> to that maintainer "I don't care about your toilet mouth, you've just
> given me the right to take my petition to caesar" - then the emotional
> response will be quite different to pain.

No.  That's just not how things work.  Patches don't get rejected
because maintainers are being rude.  Patches don't get accepted
because they are not of a sufficiently high technical quality.  And if
you spam a maintainer with bad quality patches, and they tell you what
you should do to make them better, and you actively ignore requests
about how to write better code[1], it is perfectly acceptable for
maintainers to decide to ignore said bad patch committer.  Putting bad
patch commiters on a blacklist is not a CoC violation.

[1] And no, this is not a hypothetical example.  This particular
kernel newcomer continually spammed maintainers with patches that
wouldn't even compile, and were clearly never tested.  And when the
newcomer started giving bad advice to users reporting bugs, he
ultimately got banned from LKML...

After all, we all want to make the kernel to be better.  So if someone
submits good quality code, Maintainers are going to want that code to
improve their subsystem.  Thinking that people want to go off on power
trips by rejecting perfectly sound code is a complete misdiagnosis of
the problem.

						- Ted