linux-kernel - Re: [PATCH v3 1/5] mfd: rk808: Add RK817 and RK809 support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3d96be69-e50c-187e-7d3a-75eec63d2be0@rock-chips.com>
Date:   Tue, 23 Oct 2018 15:21:50 +0800
From:   tony <tony.xie@...k-chips.com>
To:     Lee Jones <lee.jones@...aro.org>
Cc:     heiko@...ech.de, broonie@...nel.org, robh+dt@...nel.org,
        mark.rutland@....com, a.zummo@...ertech.it,
        alexandre.belloni@...tlin.com, sboyd@...nel.org,
        linux-clk@...r.kernel.org, linux-rtc@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-rockchip@...ts.infradead.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, chenjh@...k-chips.com,
        xsf@...k-chips.com, zhangqing@...k-chips.com,
        huangtao@...k-chips.com
Subject: Re: [PATCH v3 1/5] mfd: rk808: Add RK817 and RK809 support



在 2018/10/23 14:26, Lee Jones 写道:
>>>>       The rk809 and rk817 are a Power Management IC (PMIC) for multimedia
>>>>       and handheld devices. It contains the following components:
>>>>
>>>>           - Regulators
>>>>           - RTC
>>>>           - Clocking
>>>>
>>>>       Both RK809 and RK817 chips are using a similar register map,
>>>>       so we can reuse the RTC and Clocking and regulators functionality.
>>>>
>>>> Signed-off-by: Tony Xie <tony.xie@...k-chips.com>
>>>> ---
>>>>    drivers/mfd/Kconfig       |   6 +-
>>>>    drivers/mfd/rk808.c       | 218 +++++++++++++++++++++++++++++++++++++++++++++-
>>>>    include/linux/mfd/rk808.h | 172 ++++++++++++++++++++++++++++++++++++
>>>>    kernel/reboot.c           |   1 +
>>>>    4 files changed, 391 insertions(+), 6 deletions(-)
> [...]
>
>>>> diff --git a/kernel/reboot.c b/kernel/reboot.c
>>>> index e4ced88..83810d7 100644
>>>> --- a/kernel/reboot.c
>>>> +++ b/kernel/reboot.c
>>>> @@ -49,6 +49,7 @@
>>>>     */
>>>>    void (*pm_power_off_prepare)(void);
>>>> +EXPORT_SYMBOL_GPL(pm_power_off_prepare);
>>> Why do you need this where no other driver in the kernel does?
>>      There is a gpio_slp pin for RK809 and RK817，this pin has reset、power
>> down and sleep functions，so
>>      when system is going to power down, this pin is needed to switch to
>> power down function，and then we just only control
>>      this pin to high to power down the system in atf at last。
> There are other PM call-backs that you can use for this.  There
> shouldn't be any requirement to export and call functions at this
> level directly.
     I will use a shutdown call-backs from syscore to implement it.
>