linux-kernel - Re: [PATCH v2] media: venus: handle peak bitrate set property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAPBb6MUB6cOEgN3fnFfPBLMmVJQ4BbjWYeJRY1_v=oQW-vNWyg@mail.gmail.com>
Date:   Tue, 23 Oct 2018 17:08:39 +0900
From:   Alexandre Courbot <acourbot@...omium.org>
To:     mgottam@...eaurora.org
Cc:     Stanimir Varbanov <stanimir.varbanov@...aro.org>,
        Hans Verkuil <hverkuil@...all.nl>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Linux Media Mailing List <linux-media@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        linux-arm-msm@...r.kernel.org, vgarodia@...eaurora.org
Subject: Re: [PATCH v2] media: venus: handle peak bitrate set property

Hi Malathi,

On Mon, Oct 22, 2018 at 9:06 PM Malathi Gottam <mgottam@...eaurora.org> wrote:
>
> Max bitrate property is not supported for venus version 4xx.
> Return unsupported from packetization layer. Handle it in
> hfi_venus layer to exit gracefully to venc layer.
>
> Signed-off-by: Malathi Gottam <mgottam@...eaurora.org>

This seems to work, thanks!

Tested-by: Alexandre Courbot <acourbot@...omium.org>

> ---
>  drivers/media/platform/qcom/venus/hfi_cmds.c  | 2 +-
>  drivers/media/platform/qcom/venus/hfi_venus.c | 2 ++
>  2 files changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/qcom/venus/hfi_cmds.c b/drivers/media/platform/qcom/venus/hfi_cmds.c
> index e8389d8..87a4414 100644
> --- a/drivers/media/platform/qcom/venus/hfi_cmds.c
> +++ b/drivers/media/platform/qcom/venus/hfi_cmds.c
> @@ -1215,7 +1215,7 @@ static int pkt_session_set_property_1x(struct hfi_session_set_property_pkt *pkt,
>         }
>         case HFI_PROPERTY_CONFIG_VENC_MAX_BITRATE:
>                 /* not implemented on Venus 4xx */
> -               break;
> +               return -ENOTSUPP;
>         default:
>                 return pkt_session_set_property_3xx(pkt, cookie, ptype, pdata);
>         }
> diff --git a/drivers/media/platform/qcom/venus/hfi_venus.c b/drivers/media/platform/qcom/venus/hfi_venus.c
> index 1240855..9d086b9 100644
> --- a/drivers/media/platform/qcom/venus/hfi_venus.c
> +++ b/drivers/media/platform/qcom/venus/hfi_venus.c
> @@ -1355,6 +1355,8 @@ static int venus_session_set_property(struct venus_inst *inst, u32 ptype,
>         pkt = (struct hfi_session_set_property_pkt *)packet;
>
>         ret = pkt_session_set_property(pkt, inst, ptype, pdata);
> +       if (ret == -ENOTSUPP)
> +               return 0;
>         if (ret)
>                 return ret;
>
> --
> 1.9.1
>