| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <VI1PR04MB10381C2DC4052E636BA26ADA99F50@VI1PR04MB1038.eurprd04.prod.outlook.com>
Date: Tue, 23 Oct 2018 08:18:35 +0000
From: Yogesh Narayan Gaur <yogeshnarayan.gaur@....com>
To: Boris Brezillon <boris.brezillon@...tlin.com>
CC: "Cristian.Birsan@...rochip.com" <Cristian.Birsan@...rochip.com>,
Tudor Ambarus <tudor.ambarus@...rochip.com>,
"richard@....at" <richard@....at>, Mark Brown <broonie@...nel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"nicolas.ferre@...rochip.com" <nicolas.ferre@...rochip.com>,
"marek.vasut@...il.com" <marek.vasut@...il.com>,
"cyrille.pitchen@...rochip.com" <cyrille.pitchen@...rochip.com>,
"linux-mtd@...ts.infradead.org" <linux-mtd@...ts.infradead.org>,
Cyrille Pitchen <cyrille.pitchen@...ev4u.fr>,
"computersforpeace@...il.com" <computersforpeace@...il.com>,
"dwmw2@...radead.org" <dwmw2@...radead.org>,
"linux-arm-kernel@...ts.infradead.org"
<linux-arm-kernel@...ts.infradead.org>
Subject: RE: [PATCH v3 1/2] mtd: spi-nor: add support to non-uniform SFDP SPI
NOR flash memories
HI,
> -----Original Message-----
> From: Boris Brezillon [mailto:boris.brezillon@...tlin.com]
> Sent: Tuesday, October 23, 2018 11:10 AM
> To: Yogesh Narayan Gaur <yogeshnarayan.gaur@....com>
> Cc: Cristian.Birsan@...rochip.com; Tudor Ambarus
> <tudor.ambarus@...rochip.com>; richard@....at; Mark Brown
> <broonie@...nel.org>; linux-kernel@...r.kernel.org;
> nicolas.ferre@...rochip.com; marek.vasut@...il.com;
> cyrille.pitchen@...rochip.com; linux-mtd@...ts.infradead.org; Cyrille Pitchen
> <cyrille.pitchen@...ev4u.fr>; computersforpeace@...il.com;
> dwmw2@...radead.org; linux-arm-kernel@...ts.infradead.org
> Subject: Re: [PATCH v3 1/2] mtd: spi-nor: add support to non-uniform SFDP SPI
> NOR flash memories
>
> On Tue, 23 Oct 2018 04:47:33 +0000
> Yogesh Narayan Gaur <yogeshnarayan.gaur@....com> wrote:
>
> > Hi,
> >
> > > -----Original Message-----
[....]
>
> Ok, so now the opcode and address are matching the values in the spec.
> Can you check what's sent to the SPI controller side (in your
> ->exec_op() implementation), just to make sure the m25p80 propagates
> the information correctly? When you do that, make sure you also print the
> buswidth of each element (op->cmd.buswidth, op->addr.buswidth,
> op->dummy.buswidth and op->data.buswidth).
>
> Can you also print the read_data_mask value here.
I have added the prints in m25p80_read() and in flexspi controller prepare_lut and read_rxfifo() func.
In these have added prints for data variable of struct op and data which being read by the controller from the flash.
[ 2.091467] smpt[0]=[addr_width:00000003, read_dumy:00000008, read_opcode:00000065, data_mask:00000008]
[ 2.099113] m25p80_read, nor[op:00000065 addr_width:00000003, dummy:00000008, len:00000001
[ 2.107367] m25p80_read, cmd[opcode:65 bwidth:1] aadr[val:4, nbytes:3, bwidth:1]
[ 2.114753] m25p80_read, dummy[nbytes:1 bwidth:1] data[bwidth:1, nbytes:1]
[ 2.121706] nxp_fspi_prepare_lut cmd[opcode:65 bwidth:1] aadr[val:4, nbytes:3, bwidth:1]
[ 2.129786] dummy[nbytes:1 bwidth:1] data[dir:0 bwidth:1, nbytes:1]
[ 2.136132] nxp-fspi 20c0000.flexspi: CMD[65] lutval[0:8180465 1:24003008 2:0 3:0]
[ 2.144223] nxp_fspi_read_rxfifo, ReadData op.buf[0x00]
[ 2.151004] smpt_read[1] addr[00000004], data_byte[00000000] err:00000000
[ 2.157782] smpt[2]=[addr_width:00000003, read_dumy:00000008, read_opcode:00000065, data_mask:00000004]
[ 2.165429] m25p80_read, nor[op:00000065 addr_width:00000003, dummy:00000008, len:00000001
[ 2.173683] m25p80_read, cmd[opcode:65 bwidth:1] aadr[val:2, nbytes:3, bwidth:1]
[ 2.181068] m25p80_read, dummy[nbytes:1 bwidth:1] data[bwidth:1, nbytes:1]
[ 2.188021] nxp_fspi_prepare_lut cmd[opcode:65 bwidth:1] aadr[val:2, nbytes:3, bwidth:1]
[ 2.196101] dummy[nbytes:1 bwidth:1] data[dir:0 bwidth:1, nbytes:1]
[ 2.202447] nxp-fspi 20c0000.flexspi: CMD[65] lutval[0:8180465 1:24003008 2:0 3:0]
[ 2.210539] nxp_fspi_read_rxfifo, ReadData op.buf[0x02]
[ 2.217319] smpt_read[3] addr[00000002], data_byte[00000002] err:00000000
[ 2.224098] smpt[4]=[addr_width:00000003, read_dumy:00000008, read_opcode:00000065, data_mask:00000002]
[ 2.231744] m25p80_read, nor[op:00000065 addr_width:00000003, dummy:00000008, len:00000001
[ 2.239998] m25p80_read, cmd[opcode:65 bwidth:1] aadr[val:4, nbytes:3, bwidth:1]
[ 2.247383] m25p80_read, dummy[nbytes:1 bwidth:1] data[bwidth:1, nbytes:1]
[ 2.254336] nxp_fspi_prepare_lut cmd[opcode:65 bwidth:1] aadr[val:4, nbytes:3, bwidth:1]
[ 2.262416] dummy[nbytes:1 bwidth:1] data[dir:0 bwidth:1, nbytes:1]
[ 2.268762] nxp-fspi 20c0000.flexspi: CMD[65] lutval[0:8180465 1:24003008 2:0 3:0]
[ 2.276854] nxp_fspi_read_rxfifo, ReadData op.buf[0x00]
[ 2.283634] smpt_read[5] addr[00000004], data_byte[00000000] err:00000000
[ 2.290412] spi_nor_get_map_in_use:2915 map_id=0 smpt_len:16 i=:6
[ 2.296496] End [addr_width:00000003, read_dumy:00000008, read_opcode:00000065] ReturnVal:00000000
[ 2.305444] spi_nor_parse_smpt:3065
[ 2.308924] m25p80 spi0.0: failed to parse SMPT (err = -22)
>
> Next thing you can do is read the CR2NV reg (using the RDAR command) and
> check the RL (Read Latency) and AL (Address Length) values.
Please let me know how to read CR2NV register.
--
Regards,
Yogesh Gaur
>
> > [ 1.767710] spi_nor_get_map_in_use:2915 map_id=0 smpt_len:16 i=:6
> > [ 1.773794] End [addr_width:00000003, read_dumy:00000008,
> read_opcode:00000065] ReturnVal:00000000
> > [ 1.781092] spi_nor_parse_smpt:3065
> > [ 1.784573] m25p80 spi0.0: failed to parse SMPT (err = -22)
> > [ 1.790153] m25p80 spi0.0: s25fl512s (65536 Kbytes)
> >
> >
> > Code:
> > for (i = 0; i< smpt_len; i+=2) {
> > if ((smpt[i] & SMPT_DESC_TYPE_MAP))
> > break;
> >
> > read_data_mask = SMPT_CMD_READ_DATA(smpt[i]);
> > nor->addr_width = spi_nor_smpt_addr_width(nor, smpt[i]);
> > if (!nor->addr_width)
> > nor->addr_width = 3;
> >
> > nor->read_dummy = 8;
> > nor->read_opcode = SMPT_CMD_OPCODE(smpt[i]);
> > pr_info("smpt[%d]=[addr_width:%08x, read_dumy:%08x,
> > read_opcode:%08x]\n", i, nor->addr_width, nor->read_dummy,
> > nor->read_opcode);
> >
> > addr = smpt[i + 1];
> >
> > err = spi_nor_read_raw(nor, addr, 1, &data_byte);
> > pr_info("smpt_read[%d] addr[%08x], data_byte[%08x] err:%08x\n",
> (i+1), addr, data_byte, err);
> > if (err)
> > goto out;
> >
> > /*
> > * Build an index value that is used to select the Sector Map
> > * Configuration that is currently in use.
> > */
> > map_id = map_id << 1 | !!(data_byte & read_data_mask);
> > map_id_is_valid = true;
> > }
> >
> > if (map_id_is_valid)
> > pr_info("%s:%i map_id=%d smpt_len:%d i=:%d\n", __func__,
> __LINE__, map_id, smpt_len, i);
> > else
> > pr_info("%s:%i NO map_id\n", __func__, __LINE__);
> >
> > for (nmaps = 0; i< smpt_len; nmaps++) {
> > if(!(smpt[i] & SMPT_DESC_TYPE_MAP)) {
> > i += 2;
> > continue;
> > }
> >
> > if(!map_id_is_valid) {
> > if (nmaps) {
> > ret = NULL;
> > break;
> > }
> >
> > ret = smpt+i;
> > } else if (map_id == SMPT_MAP_ID(smpt[i])) {
> > ret = smpt+i;
> > break;
> > }
> >
> > /* increment the table index to the next map */
> > i += SMPT_MAP_REGION_COUNT(smpt[i]) + 1;
> > }
> >
> > pr_info("End [addr_width:%08x, read_dumy:%08x,
> > read_opcode:%08x] ReturnVal:%08x\n", nor->addr_width, nor->read_dummy,
> > nor->read_opcode, ret);
> >
> > --
> > Thanks
> > Yogesh Gaur.
> >
> > > Thanks,
> > >
> > > Boris
Powered by blists - more mailing lists