linux-kernel - [PATCH] security: fix documentation for the socket_getpeersec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20181023111450.31837-1-efremov@linux.com>
Date:   Tue, 23 Oct 2018 14:14:50 +0300
From:   efremov@...ux.com
To:     James Morris <jmorris@...ei.org>
Cc:     Denis Efremov <efremov@...ux.com>,
        "Serge E. Hallyn" <serge@...lyn.com>,
        Eric Paris <eparis@...hat.com>,
        Paul Moore <paul@...l-moore.com>,
        Kees Cook <keescook@...omium.org>,
        John Johansen <john.johansen@...onical.com>,
        Catherine Zhang <cxzhang@...son.ibm.com>,
        linux-kernel@...r.kernel.org
Subject: [PATCH] security: fix documentation for the socket_getpeersec_dgram hook

From: Denis Efremov <efremov@...ux.com>

The socket_getpeersec_dgram hook was changed in the commit
"[AF_UNIX]: Kernel memory leak fix for af_unix datagram getpeersec patch"
(dc49c1f94e34). The arguments @secdata and @seclen were changed to @sock
and @secid. This patch updates the documentation accordingly.

Signed-off-by: Denis Efremov <efremov@...ux.com>
---
 include/linux/lsm_hooks.h | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/include/linux/lsm_hooks.h b/include/linux/lsm_hooks.h
index ae3766720264..a598e601ccb3 100644
--- a/include/linux/lsm_hooks.h
+++ b/include/linux/lsm_hooks.h
@@ -861,9 +861,9 @@
  *	the IP_PASSSEC option via getsockopt.  It can then retrieve the
  *	security state returned by this hook for a packet via the SCM_SECURITY
  *	ancillary message type.
- *	@skb is the skbuff for the packet being queried
- *	@secdata is a pointer to a buffer in which to copy the security data
- *	@seclen is the maximum length for @secdata
+ *	@sock contains the socket structure.
+ *	@skb is the skbuff for the packet being queried.
+ *	@secid: pointer to where to put the secid of the packet.
  *	Return 0 on success, error on failure.
  * @sk_alloc_security:
  *	Allocate and attach a security structure to the sk->sk_security field,
-- 
2.17.2