linux-kernel - Re: [PATCH] libertas: remove set but not used variable 'int

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <25ed3d0b71eb34e121f2d7a8d936665d7720270f.camel@v3.sk>
Date:   Tue, 23 Oct 2018 16:23:09 +0200
From:   Lubomir Rintel <lkundrak@...sk>
To:     zhong jiang <zhongjiang@...wei.com>, kvalo@...eaurora.org
Cc:     davem@...emloft.net, libertas-dev@...ts.infradead.org,
        linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] libertas: remove set but not used variable 'int_type'

On Tue, 2018-10-23 at 11:32 +0800, zhong jiang wrote:
> int_type is not used after setting its value. It is safe to remove
> the unused variable.

Hi. I believe your colleague has sent an equivalent patch a few days
ago in <1539569795-176889-1-git-send-email-yuehaibing@...wei.com>:

https://lore.kernel.org/linux-wireless/1539569795-176889-1-git-send-email-yuehaibing@huawei.com/

Cheers,
Lubo

> 
> Signed-off-by: zhong jiang <zhongjiang@...wei.com>
> ---
>  drivers/net/wireless/marvell/libertas/if_spi.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/net/wireless/marvell/libertas/if_spi.c
> b/drivers/net/wireless/marvell/libertas/if_spi.c
> index 504d6e0..7c3224b 100644
> --- a/drivers/net/wireless/marvell/libertas/if_spi.c
> +++ b/drivers/net/wireless/marvell/libertas/if_spi.c
> @@ -796,15 +796,13 @@ static void if_spi_h2c(struct if_spi_card
> *card,
>  {
>  	struct lbs_private *priv = card->priv;
>  	int err = 0;
> -	u16 int_type, port_reg;
> +	u16 port_reg;
>  
>  	switch (type) {
>  	case MVMS_DAT:
> -		int_type = IF_SPI_CIC_TX_DOWNLOAD_OVER;
>  		port_reg = IF_SPI_DATA_RDWRPORT_REG;
>  		break;
>  	case MVMS_CMD:
> -		int_type = IF_SPI_CIC_CMD_DOWNLOAD_OVER;
>  		port_reg = IF_SPI_CMD_RDWRPORT_REG;
>  		break;
>  	default: