linux-kernel - Re: [PATCH stable v2 1/2] termios, tty/tty

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 23 Oct 2018 15:53:51 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     "H. Peter Anvin (Intel)" <hpa@...or.com>
Cc:     linux-kernel@...r.kernel.org, linux-serial@...r.kernel.org,
        Jiri Slaby <jslaby@...e.com>,
        Al Viro <viro@...iv.linux.org.uk>,
        Richard Henderson <rth@...ddle.net>,
        Ivan Kokshaysky <ink@...assic.park.msu.ru>,
        Matt Turner <mattst88@...il.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Kate Stewart <kstewart@...uxfoundation.org>,
        Philippe Ombredanne <pombredanne@...b.com>,
        Eugene Syromiatnikov <esyr@...hat.com>,
        linux-alpha@...r.kernel.org, Alan Cox <alan@...rguk.ukuu.org.uk>,
        stable@...r.kernel.org
Subject: Re: [PATCH stable v2 1/2] termios, tty/tty_baudrate.c: fix buffer
 overrun

On Mon, Oct 22, 2018 at 09:19:04AM -0700, H. Peter Anvin (Intel) wrote:
> From: "H. Peter Anvin" <hpa@...or.com>
> 
> On architectures with CBAUDEX == 0 (Alpha and PowerPC), the code in tty_baudrate.c does
> not do any limit checking on the tty_baudrate[] array, and in fact a
> buffer overrun is possible on both architectures. Add a limit check to
> prevent that situation.
> 
> This will be followed by a much bigger cleanup/simplification patch.
> 
> Signed-off-by: H. Peter Anvin (Intel) <hpa@...or.com>
> Requested-by: Cc: Johan Hovold <johan@...nel.org>
> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Cc: Jiri Slaby <jslaby@...e.com>
> Cc: Al Viro <viro@...iv.linux.org.uk>
> Cc: Richard Henderson <rth@...ddle.net>
> Cc: Ivan Kokshaysky <ink@...assic.park.msu.ru>
> Cc: Matt Turner <mattst88@...il.com>
> Cc: Thomas Gleixner <tglx@...utronix.de>
> Cc: Kate Stewart <kstewart@...uxfoundation.org>
> Cc: Philippe Ombredanne <pombredanne@...b.com>
> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Cc: Eugene Syromiatnikov <esyr@...hat.com>
> Cc: <linux-alpha@...r.kernel.org>
> Cc: <linux-serial@...r.kernel.org>
> Cc: Alan Cox <alan@...rguk.ukuu.org.uk>
> Cc: <stable@...r.kernel.org>
> ---
>  drivers/tty/tty_baudrate.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

As I think Al's big termios cleanups are going to be hitting Linus's
tree soon, do you know how these patches interact with that?

This patch seems like it will not, so I'll be glad to queue that up
after my first round of patches get merged to Linus later this week, but
the second one worries me.

thanks,

greg k-h