linux-kernel - Re: [PATCH v3 1/5] dt-bindings: phy-qcom-qmp: Fix register underspecification

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20181023153517.GA24710@bogus>
Date:   Tue, 23 Oct 2018 10:35:17 -0500
From:   Rob Herring <robh@...nel.org>
To:     Evan Green <evgreen@...omium.org>
Cc:     Andy Gross <andy.gross@...aro.org>,
        Kishon Vijay Abraham I <kishon@...com>,
        Douglas Anderson <dianders@...omium.org>,
        Stephen Boyd <swboyd@...omium.org>, devicetree@...r.kernel.org,
        Can Guo <cang@...eaurora.org>, linux-kernel@...r.kernel.org,
        Manu Gautam <mgautam@...eaurora.org>,
        Mark Rutland <mark.rutland@....com>
Subject: Re: [PATCH v3 1/5] dt-bindings: phy-qcom-qmp: Fix register
 underspecification

On Mon, Oct 22, 2018 at 01:50:58PM -0700, Evan Green wrote:
> Add register regions for the second lane of dual-lane nodes.
> This additional specification is needed so that the driver can stop
> reaching beyond the tx and rx register allocations to get at the
> second lane registers in a dual-lane PHY.
> 
> While in there, document #clock-cells as optional for PHYs that don't
> provide a pipe clock. Also, document the pcs_misc register region, which
> was being quietly supplied and used.
> 
> Signed-off-by: Evan Green <evgreen@...omium.org>
> Reviewed-by: Douglas Anderson <dianders@...omium.org>
> 
> ---
> 
> Changes in v3: None
> Changes in v2:
> - Added dt bindings change, corresponding driver fixup, and USB PHY fixup

Please see my reply on v2.

> 
>  .../devicetree/bindings/phy/qcom-qmp-phy.txt       | 73 +++++++++++++++++++---
>  1 file changed, 65 insertions(+), 8 deletions(-)