linux-kernel - Re: [PATCH] security: fix documentation for the task

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAGXu5jJp-FeGG37ZqVbaj+Gs6NuJac=Kcs-VAK_X4N5OOU9O=g@mail.gmail.com>
Date:   Tue, 23 Oct 2018 12:28:21 -0700
From:   Kees Cook <keescook@...omium.org>
To:     efremov@...ux.com
Cc:     KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>,
        James Morris <jmorris@...ei.org>,
        "Serge E. Hallyn" <serge@...lyn.com>,
        Eric Paris <eparis@...hat.com>,
        Paul Moore <paul@...l-moore.com>,
        John Johansen <john.johansen@...onical.com>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] security: fix documentation for the task_setscheduler hook

On Tue, Oct 23, 2018 at 4:12 AM,  <efremov@...ux.com> wrote:
> From: Denis Efremov <efremov@...ux.com>
>
> The task_setscheduler hook was changed in the commit
> "security: remove unused parameter from security_task_setscheduler()"
> (b0ae19811375). The arguments @policy, @lp were removed from the hook.
> This patch updates the documentation accordingly.
>
> Signed-off-by: Denis Efremov <efremov@...ux.com>

Reviewed-by: Kees Cook <keescook@...omium.org>

-Kees

> ---
>  include/linux/lsm_hooks.h | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/include/linux/lsm_hooks.h b/include/linux/lsm_hooks.h
> index accf6f34ac8e..ae3766720264 100644
> --- a/include/linux/lsm_hooks.h
> +++ b/include/linux/lsm_hooks.h
> @@ -655,10 +655,8 @@
>   *     Return 0 if permission is granted.
>   * @task_setscheduler:
>   *     Check permission before setting scheduling policy and/or parameters of
> - *     process @p based on @policy and @lp.
> + *     process @p.
>   *     @p contains the task_struct for process.
> - *     @policy contains the scheduling policy.
> - *     @lp contains the scheduling parameters.
>   *     Return 0 if permission is granted.
>   * @task_getscheduler:
>   *     Check permission before obtaining scheduling information for process
> --
> 2.17.2
>



-- 
Kees Cook