linux-kernel - Re: [PATCH] security: fix documentation for the path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAGXu5j+wOjprJ2DJSSXyWOkUAH8F=g84gvv0JFCJ3F81Q212Ww@mail.gmail.com>
Date:   Tue, 23 Oct 2018 12:29:23 -0700
From:   Kees Cook <keescook@...omium.org>
To:     efremov@...ux.com
Cc:     Al Viro <viro@...iv.linux.org.uk>,
        James Morris <jmorris@...ei.org>,
        "Serge E. Hallyn" <serge@...lyn.com>,
        Eric Paris <eparis@...hat.com>,
        Paul Moore <paul@...l-moore.com>,
        John Johansen <john.johansen@...onical.com>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] security: fix documentation for the path_chmod hook

On Tue, Oct 23, 2018 at 4:16 AM,  <efremov@...ux.com> wrote:
> From: Denis Efremov <efremov@...ux.com>
>
> The path_chmod hook was changed in the commit
> "switch security_path_chmod() to struct path *" (cdcf116d44e7).
> The argument @mnt was removed from the hook, @dentry was changed
> to @path. This patch updates the documentation accordingly.
>
> Signed-off-by: Denis Efremov <efremov@...ux.com>

Reviewed-by: Kees Cook <keescook@...omium.org>

-Kees

> ---
>  include/linux/lsm_hooks.h | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/include/linux/lsm_hooks.h b/include/linux/lsm_hooks.h
> index a598e601ccb3..596351f7c3d1 100644
> --- a/include/linux/lsm_hooks.h
> +++ b/include/linux/lsm_hooks.h
> @@ -304,8 +304,7 @@
>   *     Return 0 if permission is granted.
>   * @path_chmod:
>   *     Check for permission to change DAC's permission of a file or directory.
> - *     @dentry contains the dentry structure.
> - *     @mnt contains the vfsmnt structure.
> + *     @path contains the path structure.
>   *     @mode contains DAC's mode.
>   *     Return 0 if permission is granted.
>   * @path_chown:
> --
> 2.17.2
>



-- 
Kees Cook