linux-kernel - Re: [RFC PATCH] cgroup, netclassid: add a preemption point to write

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20181023195848.GC4182586@devbig004.ftw2.facebook.com>
Date:   Tue, 23 Oct 2018 12:58:48 -0700
From:   Tejun Heo <tj@...nel.org>
To:     Michal Hocko <mhocko@...nel.org>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Johannes Weiner <hannes@...xchg.org>, cgroups@...r.kernel.org,
        netdev@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
        Michal Hocko <mhocko@...e.com>
Subject: Re: [RFC PATCH] cgroup, netclassid: add a preemption point to
 write_classid

On Thu, Oct 18, 2018 at 10:56:17AM +0200, Michal Hocko wrote:
> From: Michal Hocko <mhocko@...e.com>
> 
> We have seen a customer complaining about soft lockups on !PREEMPT
> kernel config with 4.4 based kernel
...
> If a cgroup has many tasks with many open file descriptors then we would
> end up in a large loop without any rescheduling point throught the
> operation. Add cond_resched once per task.
> 
> Signed-off-by: Michal Hocko <mhocko@...e.com>

Applied to cgroup/for-4.20.

Thanks.

-- 
tejun