linux-kernel - Re: [RFC PATCH 0/2] improve vmalloc allocation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181023200923.GB25444@bombadil.infradead.org>
Date:   Tue, 23 Oct 2018 13:09:23 -0700
From:   Matthew Wilcox <willy@...radead.org>
To:     Shuah Khan <shuah@...nel.org>
Cc:     Joel Fernandes <joel@...lfernandes.org>,
        Michal Hocko <mhocko@...nel.org>,
        Uladzislau Rezki <urezki@...il.com>,
        Kees Cook <keescook@...omium.org>,
        Andrew Morton <akpm@...ux-foundation.org>, linux-mm@...ck.org,
        LKML <linux-kernel@...r.kernel.org>,
        Thomas Garnier <thgarnie@...gle.com>,
        Oleksiy Avramchenko <oleksiy.avramchenko@...ymobile.com>,
        Steven Rostedt <rostedt@...dmis.org>,
        Joel Fernandes <joelaf@...gle.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...e.hu>, Tejun Heo <tj@...nel.org>,
        maco@...roid.com
Subject: Re: [RFC PATCH 0/2] improve vmalloc allocation

On Tue, Oct 23, 2018 at 01:48:32PM -0600, Shuah Khan wrote:
> On 10/23/2018 01:30 PM, Joel Fernandes wrote:
> > On Tue, Oct 23, 2018 at 11:13:36AM -0600, Shuah Khan wrote:
> >> I like this proposal. I think we will open up lot of test opportunities with
> >> this approach.
> >>
> >> Maybe we can use this stress test as a pilot and see where it takes us.
> > 
> > I am a bit worried that such an EXPORT_SYMBOL_KSELFTEST mechanism can be abused by
> > out-of-tree module writers to call internal functionality.
> 
> That is  valid concern to consider before we go forward with the proposal.
> 
> We could wrap EXPORT_SYMBOL_KSELFTEST this in an existing debug option. This could
> be fine grained for each sub-system for its debug option. We do have a few of these
> now

This all seems far more complicated than my proposed solution.