linux-kernel - Re: [PATCH v6 07/15] tracing: Move hist trigger key printing into a separate function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1540329842.6502.9.camel@kernel.org>
Date:   Tue, 23 Oct 2018 16:24:02 -0500
From:   Tom Zanussi <zanussi@...nel.org>
To:     Masami Hiramatsu <mhiramat@...nel.org>
Cc:     rostedt@...dmis.org, tglx@...utronix.de, namhyung@...nel.org,
        vedang.patel@...el.com, bigeasy@...utronix.de,
        joel@...lfernandes.org, mathieu.desnoyers@...icios.com,
        julia@...com, linux-kernel@...r.kernel.org,
        linux-rt-users@...r.kernel.org
Subject: Re: [PATCH v6 07/15] tracing: Move hist trigger key printing into a
 separate function

Hi Masami,

On Tue, 2018-10-23 at 23:37 +0900, Masami Hiramatsu wrote:
> Hi Tom,
> 
> On Thu, 11 Oct 2018 16:02:04 -0500
> Tom Zanussi <zanussi@...nel.org> wrote:
> 
> > From: Tom Zanussi <tom.zanussi@...ux.intel.com>
> > 
> > Future patches will want to print a histogram key outside a
> > histogram
> > - add and use hist_trigger_print_key() for that purpose.
> 
> Hmm, I think this change should be done with such user code, because
> without
> the user code I can not decide it is good or not.
> 

OK, will move it into the following patch, 'tracing: Add hist trigger
snapshot() action'.

Thanks,

Tom