linux-kernel - Re: [PATCH] gpu/drm/virtio/virtgpu_vq.c: Use kmem_cache

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 23 Oct 2018 09:36:55 +0530
From:   Souptick Joarder <jrdr.linux@...il.com>
To:     Sabyasachi Gupta <sabyasachi.linux@...il.com>
Cc:     airlied@...ux.ie, Gerd Hoffmann <kraxel@...hat.com>,
        dri-devel@...ts.freedesktop.org,
        virtualization@...ts.linux-foundation.org,
        linux-kernel@...r.kernel.org,
        Brajeswar Ghosh <brajeswar.linux@...il.com>
Subject: Re: [PATCH] gpu/drm/virtio/virtgpu_vq.c: Use kmem_cache_zalloc

On Fri, Oct 19, 2018 at 9:30 PM Sabyasachi Gupta
<sabyasachi.linux@...il.com> wrote:
>
> Replaced kmem_cache_alloc + memset with kmem_cache_zalloc

Put a new line gap in between these two lines and send v2.

> Signed-off-by: Sabyasachi Gupta <sabyasachi.linux@...il.com>
> ---
>  drivers/gpu/drm/virtio/virtgpu_vq.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/virtio/virtgpu_vq.c b/drivers/gpu/drm/virtio/virtgpu_vq.c
> index 020070d..e001b79 100644
> --- a/drivers/gpu/drm/virtio/virtgpu_vq.c
> +++ b/drivers/gpu/drm/virtio/virtgpu_vq.c
> @@ -98,10 +98,9 @@ virtio_gpu_get_vbuf(struct virtio_gpu_device *vgdev,
>  {
>         struct virtio_gpu_vbuffer *vbuf;
>
> -       vbuf = kmem_cache_alloc(vgdev->vbufs, GFP_KERNEL);
> +       vbuf = kmem_cache_zalloc(vgdev->vbufs, GFP_KERNEL);
>         if (!vbuf)
>                 return ERR_PTR(-ENOMEM);
> -       memset(vbuf, 0, VBUFFER_SIZE);
>
>         BUG_ON(size > MAX_INLINE_CMD_SIZE);
>         vbuf->buf = (void *)vbuf + sizeof(*vbuf);
> --
> 2.7.4
>