linux-kernel - Re: [PATCH 4/5] spi: lpspi: enable runtime pm for lpspi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 24 Oct 2018 14:06:26 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Clark Wang <xiaoning.wang@....com>
Cc:     kbuild-all@...org, "broonie@...nel.org" <broonie@...nel.org>,
        "linux-spi@...r.kernel.org" <linux-spi@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Clark Wang <xiaoning.wang@....com>, Han Xu <han.xu@....com>
Subject: Re: [PATCH 4/5] spi: lpspi: enable runtime pm for lpspi

Hi Clark,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on spi/for-next]
[also build test ERROR on next-20181019]
[cannot apply to v4.19]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Clark-Wang/spi-lpspi-Add-slave-mode-support-for-imx7ulp/20181024-125200
base:   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next
config: mips-allyesconfig (attached as .config)
compiler: mips-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=7.2.0 make.cross ARCH=mips 

All errors (new ones prefixed by >>):

   drivers//spi/spi-fsl-lpspi.c: In function 'fsl_lpspi_transfer_one':
   drivers//spi/spi-fsl-lpspi.c:399:8: error: implicit declaration of function 'fsl_lpspi_txfifo_empty'; did you mean 'fsl_lpspi_set_cmd'? [-Werror=implicit-function-declaration]
     ret = fsl_lpspi_txfifo_empty(fsl_lpspi);
           ^~~~~~~~~~~~~~~~~~~~~~
           fsl_lpspi_set_cmd
   drivers//spi/spi-fsl-lpspi.c: In function 'fsl_lpspi_suspend':
>> drivers//spi/spi-fsl-lpspi.c:622:2: error: implicit declaration of function 'pinctrl_pm_select_sleep_state' [-Werror=implicit-function-declaration]
     pinctrl_pm_select_sleep_state(dev);
     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers//spi/spi-fsl-lpspi.c: In function 'fsl_lpspi_resume':
>> drivers//spi/spi-fsl-lpspi.c:637:2: error: implicit declaration of function 'pinctrl_pm_select_default_state'; did you mean 'irq_set_default_host'? [-Werror=implicit-function-declaration]
     pinctrl_pm_select_default_state(dev);
     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
     irq_set_default_host
   cc1: some warnings being treated as errors

vim +/pinctrl_pm_select_sleep_state +622 drivers//spi/spi-fsl-lpspi.c

   616	
   617	#ifdef CONFIG_PM_SLEEP
   618	static int fsl_lpspi_suspend(struct device *dev)
   619	{
   620		int ret;
   621	
 > 622		pinctrl_pm_select_sleep_state(dev);
   623		ret = pm_runtime_force_suspend(dev);
   624		return ret;
   625	}
   626	
   627	static int fsl_lpspi_resume(struct device *dev)
   628	{
   629		int ret;
   630	
   631		ret = pm_runtime_force_resume(dev);
   632		if (ret) {
   633			dev_err(dev, "Error in resume: %d\n", ret);
   634			return ret;
   635		}
   636	
 > 637		pinctrl_pm_select_default_state(dev);
   638	
   639		return 0;
   640	}
   641	#endif /* CONFIG_PM_SLEEP */
   642	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (57610 bytes)