linux-kernel - Re: [PATCH v15 1/2] leds: core: Introduce LED pattern trigger

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181024083143.GA24165@amd>
Date:   Wed, 24 Oct 2018 10:31:43 +0200
From:   Pavel Machek <pavel@....cz>
To:     Jacek Anaszewski <jacek.anaszewski@...il.com>
Cc:     Baolin Wang <baolin.wang@...aro.org>, rteysseyre@...il.com,
        bjorn.andersson@...aro.org, broonie@...nel.org,
        linus.walleij@...aro.org, linux-leds@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v15 1/2] leds: core: Introduce LED pattern trigger

Hi!

> > +
> > +		The gradual dimming format of the software pattern values should be:
> > +		"brightness_1 duration_1 brightness_2 duration_2 brightness_3
> > +		duration_3 ...". For example:
> > +
> > +		echo 0 1000 255 2000 > pattern
> > +
> > +		It will make the LED go gradually from zero-intensity to max (255)
> > +		intensity in 1000 milliseconds, then back to zero intensity in 2000
> > +		milliseconds:
> > +
> > +		LED brightness
> > +		    ^
> > +		255-|       / \            / \            /
> > +		    |      /    \         /    \         /
> > +		    |     /       \      /       \      /
> > +		    |    /          \   /          \   /
> > +		  0-|   /             \/             \/
> > +		    +---0----1----2----3----4----5----6------------> time (s)
> > +

Ok, so I got around to testing this.

echo "0 1000 10 2550 0 1000 0 100" > pattern

makes expected pattern [  .-xXx-.  ].

But when I do

echo "0 1000 10 2550 0 1000" > pattern

I only get expected pattern on the first iteration, then I get
[    Xx-.   ].

I'm using led-controller:flash on nokia n900 (so everything in
software).

> OK, let's abide by constant update interval for now.
> 
> Thank you for your work on this patch set throughout
> all these months. We will have -rc8, so one week of testing
> before sending upstream should be enough.
> 
> Patch set applied to the for-next branch of linux-leds.git.

Thanks!
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Download attachment "signature.asc" of type "application/pgp-signature" (182 bytes)