linux-kernel - Re: [PATCH 5/8] arm: convert to generic builtin command line

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20181024091600.GT30658@n2100.armlinux.org.uk>
Date:   Wed, 24 Oct 2018 10:16:00 +0100
From:   Russell King - ARM Linux <linux@...linux.org.uk>
To:     Maksym Kokhan <maksym.kokhan@...ballogic.com>
Cc:     Ard Biesheuvel <ard.biesheuvel@...aro.org>,
        Daniel Walker <dwalker@...o99.com>,
        Daniel Walker <danielwa@...co.com>,
        Andrii Bordunov <aborduno@...co.com>,
        Ruslan Bilovol <rbilovol@...co.com>,
        linux-kernel@...r.kernel.org, linux-efi@...r.kernel.org
Subject: Re: [PATCH 5/8] arm: convert to generic builtin command line

On Thu, Sep 27, 2018 at 07:56:33PM +0300, Maksym Kokhan wrote:
> From: Daniel Walker <danielwa@...co.com>
> 
> This updates the arm 32bit code to use the CONFIG_GENERIC_CMDLINE
> option.

Sorry, I can't accept this change.  While it may seem to be a good idea
to unify this between different architectures, the problem this presents
is that it breaks people's existing .config, and almost every single
defconfig that we have in arch/arm/configs/

The breakage is such that it will end up wiping out (eg) the setting of
CONFIG_CMDLINE entirely, and only if it's realised and retrieved
immediately from .config.old, it will be lost.

-- 
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
According to speedtest.net: 11.9Mbps down 500kbps up