lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 24 Oct 2018 15:37:49 +0000 From: Michael Kelley <mikelley@...rosoft.com> To: KY Srinivasan <kys@...rosoft.com>, "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "devel@...uxdriverproject.org" <devel@...uxdriverproject.org>, "olaf@...fle.de" <olaf@...fle.de>, "apw@...onical.com" <apw@...onical.com>, "jasowang@...hat.com" <jasowang@...hat.com>, Stephen Hemminger <sthemmin@...rosoft.com>, vkuznets <vkuznets@...hat.com> CC: Dexuan Cui <decui@...rosoft.com>, Haiyang Zhang <haiyangz@...rosoft.com>, "Stable@...r.kernel.org" <Stable@...r.kernel.org> Subject: RE: [PATCH V2 3/5] Drivers: hv: kvp: Fix the recent regression caused by incorrect clean-up From: kys@...uxonhyperv.com <kys@...uxonhyperv.com> Sent: Wednesday, October 17, 2018 10:10 PM > From: Dexuan Cui <decui@...rosoft.com> > > In kvp_send_key(), we do need call process_ib_ipinfo() if > message->kvp_hdr.operation is KVP_OP_GET_IP_INFO, because it turns out > the userland hv_kvp_daemon needs the info of operation, adapter_id and > addr_family. With the incorrect fc62c3b1977d, the host can't get the > VM's IP via KVP. > > And, fc62c3b1977d added a "break;", but actually forgot to initialize > the key_size/value in the case of KVP_OP_SET, so the default key_size of > 0 is passed to the kvp daemon, and the pool files > /var/lib/hyperv/.kvp_pool_* can't be updated. > > This patch effectively rolls back the previous fc62c3b1977d, and > correctly fixes the "this statement may fall through" warnings. > > This patch is tested on WS 2012 R2 and 2016. > > Fixes: fc62c3b1977d ("Drivers: hv: kvp: Fix two "this statement may fall through" warnings") > Signed-off-by: Dexuan Cui <decui@...rosoft.com> > Cc: K. Y. Srinivasan <kys@...rosoft.com> > Cc: Haiyang Zhang <haiyangz@...rosoft.com> > Cc: Stephen Hemminger <sthemmin@...rosoft.com> > Cc: <Stable@...r.kernel.org> > Signed-off-by: K. Y. Srinivasan <kys@...rosoft.com> > --- > drivers/hv/hv_kvp.c | 26 ++++++++++++++++++++++---- > 1 file changed, 22 insertions(+), 4 deletions(-) > Reviewed-by: Michael Kelley <mikelley@...rosoft.com>
Powered by blists - more mailing lists