| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Wed, 24 Oct 2018 08:58:20 -0700
From: Randy Dunlap <rdunlap@...radead.org>
To: Sven Van Asbroeck <svendev@...x.com>, lee.jones@...aro.org,
robh+dt@...nel.org, mark.rutland@....com, afaerber@...e.de,
treding@...dia.com, david@...hnology.com, noralf@...nnes.org,
johan@...nel.org, monstr@...str.eu, michal.vokac@...ft.com,
arnd@...db.de, gregkh@...uxfoundation.org, john.garry@...wei.com,
andriy.shevchenko@...ux.intel.com, geert+renesas@...der.be,
robin.murphy@....com, paul.gortmaker@...driver.com,
sebastien.bourdelin@...oirfairelinux.com, icenowy@...c.io,
yuanzhichang@...ilicon.com, stuyoder@...il.com,
linus.walleij@...aro.org, maxime.ripard@...tlin.com,
bogdan.purcareata@....com
Cc: linux-kernel@...r.kernel.org, devicetree@...r.kernel.org
Subject: Re: [PATCH anybus v1 4/4] misc: support HMS Profinet IRT industrial
controller.
Hi,
On 10/24/18 7:24 AM, Sven Van Asbroeck wrote:
> The Anybus-S PROFINET IRT communication module provides instant integration
> to any Ethernet based LAN via SMTP, FTP, HTTP as well as PROFINET and
> Modbus-TCP. Additional protocols can be implemented on top of TCP/IP
> or UDP using the transparent socket interface.
>
> Official documentation:
> https://www.anybus.com/docs/librariesprovider7/default-document-library
> /manuals-design-guides/hms-hmsi-168-52.pdf
>
> This implementation is an Anybus-S client driver, designed to be
> instantiated by the Anybus-S bus driver when it discovers the Profinet
> card.
>
> If loaded successfully, the driver creates a /dev/profinet%d devnode,
> and a /sys/class/misc/profinet%d sysfs subdir:
> - the card can be configured with a single, atomic ioctl on the devnode;
> - the card's internal dpram is accessed by calling read/write/seek
> on the devnode.
> - the card's "fieldbus specific area" properties can be accessed via
> the sysfs dir.
>
> Signed-off-by: Sven Van Asbroeck <svendev@...x.com>
> ---
> drivers/misc/Kconfig | 11 +
> drivers/misc/Makefile | 1 +
> drivers/misc/hms-profinet.c | 747 ++++++++++++++++++++++++++++++
> include/uapi/linux/hms-common.h | 14 +
> include/uapi/linux/hms-profinet.h | 101 ++++
> 5 files changed, 874 insertions(+)
> create mode 100644 drivers/misc/hms-profinet.c
> create mode 100644 include/uapi/linux/hms-common.h
> create mode 100644 include/uapi/linux/hms-profinet.h
>
> diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig
> index 3726eacdf65d..377fea2e3003 100644
> --- a/drivers/misc/Kconfig
> +++ b/drivers/misc/Kconfig
> @@ -406,6 +406,17 @@ config SPEAR13XX_PCIE_GADGET
> entry will be created for that controller. User can use these
> sysfs node to configure PCIe EP as per his requirements.
>
> +config HMS_PROFINET
> + tristate "HMS Profinet IRT Controller (Anybus-S)"
> + select HMS_ANYBUSS_HOST
> + default n
Please drop the "default n".
> + help
> + If you say yes here you get support for the HMS Industrial
> + Networks Profinet IRT Controller.
> + This driver can also be built as a module. If so, the module
> + will be called hms-profinet.
> + If unsure, say N.
> +
> config VMWARE_BALLOON
> tristate "VMware Balloon Driver"
> depends on VMWARE_VMCI && X86 && HYPERVISOR_GUEST
> diff --git a/drivers/misc/hms-profinet.c b/drivers/misc/hms-profinet.c
> new file mode 100644
> index 000000000000..7338a49cbddd
> --- /dev/null
> +++ b/drivers/misc/hms-profinet.c
Please check multi-line comment style in this source file.
> diff --git a/include/uapi/linux/hms-profinet.h b/include/uapi/linux/hms-profinet.h
> new file mode 100644
> index 000000000000..4ae5eab8ab43
> --- /dev/null
> +++ b/include/uapi/linux/hms-profinet.h
> @@ -0,0 +1,101 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> +/*
> + * Copyright 2018 Archronix Corp. All Rights Reserved.
> + *
> + */
> +
> +#ifndef _UAPILINUX_PROFINET_H_
> +#define _UAPILINUX_PROFINET_H_
> +
> +#include <asm/types.h>
> +#include <linux/hms-common.h>
> +
> +#define PROFI_CFG_STRLEN 64
> +
> +struct ProfinetConfig {
> + struct {
> + /* addresses IN NETWORK ORDER! */
> + __u32 ip_addr;
> + __u32 subnet_msk;
> + __u32 gateway_addr;
> + __u8 is_valid:1;
> + } eth;
> + struct {
> + __u16 vendorid, deviceid;
> + __u8 is_valid:1;
> + } dev_id;
> + struct {
> + char name[PROFI_CFG_STRLEN];
> + __u8 is_valid:1;
> + } station_name;
> + struct {
> + char name[PROFI_CFG_STRLEN];
> + __u8 is_valid:1;
> + } station_type;
> + struct {
> + __u8 addr[6];
> + __u8 is_valid:1;
> + } mac_addr;
> + struct {
> + char hostname[PROFI_CFG_STRLEN];
> + char domainname[PROFI_CFG_STRLEN];
> + __u8 is_valid:1;
> + } host_domain;
> + struct {
> + __u8 enable:1;
> + __u8 is_valid:1;
> + } hicp;
> + struct {
> + __u8 enable:1;
> + __u8 is_valid:1;
> + } web_server;
> + struct {
> + __u8 disable:1;
> + } ftp_server;
> + struct {
> + __u8 enable:1;
> + } global_admin_mode;
> + struct {
> + __u8 disable:1;
> + } vfs;
> + struct {
> + /* one of HMS_SMA_CLEAR/FREEZE/SET */
> + int action;
> + __u8 is_valid:1;
> + } stop_mode;
> + struct {
> + char description[PROFI_CFG_STRLEN];
> + __u8 is_valid:1;
> + } snmp_system_descr;
> + struct {
> + char description[PROFI_CFG_STRLEN];
> + __u8 is_valid:1;
> + } snmp_iface_descr;
> + struct {
> + char description[PROFI_CFG_STRLEN];
> + __u8 is_valid:1;
> + } mib2_system_descr;
> + struct {
> + char contact[PROFI_CFG_STRLEN];
> + __u8 is_valid:1;
> + } mib2_system_contact;
> + struct {
> + char location[PROFI_CFG_STRLEN];
> + __u8 is_valid:1;
> + } mib2_system_location;
> + /* use non-volatile defaults for any properties not specified.
> + * when in doubt, keep this OFF.
> + */
> + __u8 use_nv_defaults:1;
> +};
> +
> +#define PROFINET_IOC_MAGIC 'l'
> +
> +/*
> + * Configures profinet according to the ProfinetConfig structure, and
> + * switches the card on if it was previously off.
> + */
> +#define PROFINET_IOCSETCONFIG _IOW(PROFINET_IOC_MAGIC, 1,\
> + struct ProfinetConfig)
ioctl magic numbers should be added to
Documentation/ioctl/ioctl-number.txt, please.
> +
> +#endif /* _UAPILINUX_PROFINET_H_ */
>
--
~Randy
Powered by blists - more mailing lists