linux-kernel - Re: [PATCH] V2 init/main.c Enable watchdog

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <88de4b50-b3cd-1870-8944-92163df84bb3@infradead.org>
Date:   Wed, 24 Oct 2018 09:19:01 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Laurence Oberman <loberman@...hat.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] V2 init/main.c Enable watchdog_thresh control from kernel
 line

On 10/24/18 8:53 AM, Laurence Oberman wrote:
> Both graphics and serial consoles are exposed to hard lockups
> when handling a large amount of messaging. The kernel watchdog_thresh
> parameter up to now has not been available to be set on the kernel line for
> early boot. 
> This patch allows the setting of watchdog_thresh to be increased
> when needed to avoid the hard lockups in the console code.
> 
> Signed-off-by: Laurence Oberman <loberman@...hat.com>
> ---
>  init/main.c | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/init/main.c b/init/main.c
> index e4a3160..5882750 100644
> --- a/init/main.c
> +++ b/init/main.c
> @@ -977,6 +977,15 @@ static int __init set_debug_rodata(char *str)
>  __setup("rodata=", set_debug_rodata);
>  #endif
>  
> +static int __init
> +is_watchdog_thresh_setup(char *str)
> +{
> +	get_option(&str, &watchdog_thresh);
> +	return 1;
> +}
> +__setup("watchdog_thresh=", is_watchdog_thresh_setup);
> +
> +
>  #ifdef CONFIG_STRICT_KERNEL_RWX
>  static void mark_readonly(void)
>  {
> 

Hi Laurence,

Let's make this into more of a complete patch.

a.  update the diffstat to include the Documentation change

b.  send the patch with the Documentation change as part of the same patch,
not as a separate patch (It looks like the multiple "---" lines in the
email are confusing.)

c.  send the patch to someone who can merge it: scripts/get_maintainer.pl top
suggestions are:
Thomas Gleixner <tglx@...utronix.de> or Ingo Molnar <mingo@...nel.org>

thanks,
-- 
~Randy