linux-kernel - Re: [PATCH v8 07/12] dt-bindings: mfd: Add a document for PECI client MFD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8c322777-7c35-1c2a-730f-f8de86522b96@linux.intel.com>
Date:   Wed, 24 Oct 2018 09:39:51 -0700
From:   Jae Hyun Yoo <jae.hyun.yoo@...ux.intel.com>
To:     Lee Jones <lee.jones@...aro.org>
Cc:     Mark Rutland <mark.rutland@....com>,
        Randy Dunlap <rdunlap@...radead.org>,
        linux-aspeed@...ts.ozlabs.org, devicetree@...r.kernel.org,
        Vernon Mauery <vernon.mauery@...ux.intel.com>,
        Frederic Barrat <fbarrat@...ux.vnet.ibm.com>,
        Mauro Carvalho Chehab <mchehab+samsung@...nel.org>,
        Jason M Biils <jason.m.bills@...ux.intel.com>,
        Eric Sandeen <sandeen@...hat.com>,
        Lorenzo Pieralisi <lorenzo.pieralisi@....com>,
        Jonathan Corbet <corbet@....net>, openbmc@...ts.ozlabs.org,
        linux-doc@...r.kernel.org, Kishon Vijay Abraham I <kishon@...com>,
        "Bryant G . Ly" <bryantly@...ux.vnet.ibm.com>,
        Uwe Kleine-Konig <u.kleine-koenig@...gutronix.de>,
        David Kershner <david.kershner@...sys.com>,
        Guenter Roeck <linux@...ck-us.net>, Wu Hao <hao.wu@...el.com>,
        linux-hwmon@...r.kernel.org, Jean Delvare <jdelvare@...e.com>,
        Arnd Bergmann <arnd@...db.de>,
        Philippe Ombredanne <pombredanne@...b.com>,
        Johan Hovold <johan@...nel.org>,
        Tomohiro Kusumi <kusumi.tomohiro@...il.com>,
        Rob Herring <robh+dt@...nel.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Sagar Dharia <sdharia@...eaurora.org>,
        linux-arm-kernel@...ts.infradead.org,
        Juergen Gross <jgross@...e.com>,
        Cyrille Pitchen <cyrille.pitchen@...ev4u.fr>,
        Andrew Jeffery <andrew@...id.au>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "Darrick J . Wong" <darrick.wong@...cle.com>,
        Stephen Boyd <sboyd@...eaurora.org>,
        linux-kernel@...r.kernel.org, Vinod Koul <vkoul@...nel.org>,
        James Feist <james.feist@...ux.intel.com>,
        Gustavo Pimentel <gustavo.pimentel@...opsys.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        "David S . Miller" <davem@...emloft.net>
Subject: Re: [PATCH v8 07/12] dt-bindings: mfd: Add a document for PECI client
 MFD

Hi Lee,

On 10/24/2018 12:25 AM, Lee Jones wrote:
> On Tue, 18 Sep 2018, Jae Hyun Yoo wrote:
> 
>> +Required properties:
>> +- compatible : Should be "intel,peci-client".
>> +- reg        : Should contain address of a client CPU. Address range of CPU
>> +	       clients starts from 0x30 based on PECI specification.
> 
> Nit: "start"
> 
> Would be better worded:
> 
> "According to the PECI specification client addresses start from 0x30."
> 

Yes, that would be better. Will fix it like you suggested.

Thanks for the review!

Jae