linux-kernel - Re: [PATCH 1/2] perf: Add munmap callback

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 24 Oct 2018 14:12:54 -0400
From:   "Liang, Kan" <kan.liang@...ux.intel.com>
To:     Arnaldo Carvalho de Melo <acme@...nel.org>,
        Andi Kleen <ak@...ux.intel.com>
Cc:     Peter Zijlstra <peterz@...radead.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...nel.org>, linux-kernel@...r.kernel.org,
        bp@...en8.de, Stephane Eranian <eranian@...gle.com>
Subject: Re: [PATCH 1/2] perf: Add munmap callback



On 10/24/2018 12:32 PM, Arnaldo Carvalho de Melo wrote:
> Em Wed, Oct 24, 2018 at 09:23:34AM -0700, Andi Kleen escreveu:
>>> +void perf_event_munmap(void)
>>> +{
>>> +	struct perf_cpu_context *cpuctx;
>>> +	unsigned long flags;
>>> +	struct pmu *pmu;
>>> +
>>> +	local_irq_save(flags);
>>> +	list_for_each_entry(cpuctx, this_cpu_ptr(&sched_cb_list), sched_cb_entry) {
>>
>> Would be good have a fast path here that checks for the list being empty
>> without disabling the interrupts. munmap can be somewhat hot. I think
>> it's ok to make it slower with perf running, but we shouldn't impact
>> it without perf.
> 
> Right, look at how its counterpart, perf_event_mmap() works:
> 
> void perf_event_mmap(struct vm_area_struct *vma)
> {
>          struct perf_mmap_event mmap_event;
> 
>          if (!atomic_read(&nr_mmap_events))
>                  return;
> <SNIP>
> }
> 

Thanks. I'll add the nr_mmap_events check in V2.

Thanks,
Kan