linux-kernel - Re: [PATCH] scsi/pmcraid.c: Use dma_pool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAFqt6zYpU=2FBnMHQisdTrnKR5F7BY2+hWP-NZH6kRNaTT=NJg@mail.gmail.com>
Date:   Wed, 24 Oct 2018 09:06:59 +0530
From:   Souptick Joarder <jrdr.linux@...il.com>
To:     James Bottomley <jejb@...ux.vnet.ibm.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        Sabyasachi Gupta <sabyasachi.linux@...il.com>
Cc:     linux-scsi <linux-scsi@...r.kernel.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] scsi/pmcraid.c: Use dma_pool_zalloc

On Mon, Oct 8, 2018 at 9:58 PM Souptick Joarder <jrdr.linux@...il.com> wrote:
>
> On Tue, Oct 2, 2018 at 10:53 AM Souptick Joarder <jrdr.linux@...il.com> wrote:
> >
> > Replaced dma_pool_alloc + memset with dma_pool_zalloc.
> >
> > Signed-off-by: Sabyasachi Gupta <sabyasachi.linux@...il.com>
> > Signed-off-by: Souptick Joarder <jrdr.linux@...il.com>
>
> Any comment on this patch ?

Any comment on this patch ?

>
> > ---
> >  drivers/scsi/pmcraid.c | 4 +---
> >  1 file changed, 1 insertion(+), 3 deletions(-)
> >
> > diff --git a/drivers/scsi/pmcraid.c b/drivers/scsi/pmcraid.c
> > index 4e86994..84a2734 100644
> > --- a/drivers/scsi/pmcraid.c
> > +++ b/drivers/scsi/pmcraid.c
> > @@ -4681,7 +4681,7 @@ static int pmcraid_allocate_control_blocks(struct pmcraid_instance *pinstance)
> >
> >         for (i = 0; i < PMCRAID_MAX_CMD; i++) {
> >                 pinstance->cmd_list[i]->ioa_cb =
> > -                       dma_pool_alloc(
> > +                       dma_pool_zalloc(
> >                                 pinstance->control_pool,
> >                                 GFP_KERNEL,
> >                                 &(pinstance->cmd_list[i]->ioa_cb_bus_addr));
> > @@ -4690,8 +4690,6 @@ static int pmcraid_allocate_control_blocks(struct pmcraid_instance *pinstance)
> >                         pmcraid_release_control_blocks(pinstance, i);
> >                         return -ENOMEM;
> >                 }
> > -               memset(pinstance->cmd_list[i]->ioa_cb, 0,
> > -                       sizeof(struct pmcraid_control_block));
> >         }
> >         return 0;
> >  }
> > --
> > 1.9.1
> >